-
Notifications
You must be signed in to change notification settings - Fork 148
Windows Write Event Fix #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Write Event Fix #274
Conversation
The first point LGTM. But I have some concerns about removing the write event call from I could not test this but checking the code I imagine the infinite loop also happens on linux. And if that's the case I would try to keep the behaviour consistent among the different platforms. Maybe @aykevl can confirm this? Is this intended behaviour? @Cartermel maybe we could split this PR in two and merge the first part while we clarify if the infinite loop is intended behaviour or not? I think it's something we can live with (it can probably be avoided by setting some flag to ignore your own callbacks). |
98ee2ad
to
f1c1536
Compare
sounds good, created a new PR here with the windows changes for now: #277 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@deadprogram is it fine if I merge this? |
@jagobagascon looks good to me! Thanks @Cartermel for working on this. |
fixed issue where the WriteEvent from CharacteristicConfig was not being set to the internal winrt characteristicNot sure if the second point is intended behavour? In gatts_linux.go it calls a characterisit writeEvent, but I'm assuming bluez is writing to the characterisitic for you, whereas in winrt we have to write to it manually... One of these is probably not intended..!