Fixes and improvements to connection timeouts on SoftDevices #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure an error is reported on a connection timeout. Previously it would just block forever.
This fixes the connection timeout. Previously it would try to connect for a time 16 times as much as specified by the user.
This adds support for the "connection supervision timeout", basically the connection timeout while the connection is active (as opposed to while connecting).
aykevl
force-pushed
the
sd-connect-timeout
branch
from
8325641 to
d491405
Compare
|
This is now ready for review. |
aykevl
commented
Jan 11, 2024
|
Thanks for the fixes @aykevl now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few things to better deal with connection timeouts when connecting to a peripheral from a nrf52 chip.
This depends on #211 and needs to be rebased once it is ready.