Expose ServiceData() in AdvertisementFields #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a reasonable PR, sorry I missed it. Can you rebase it on the current dev branch? There were a lot of changes in the Linux/BlueZ version so this PR will need some updates. |
dnlwgnd
added a commit
to dnlwgnd/tinygo-bluetooth
that referenced
this pull request
Feb 17, 2024
…ervicedata this was PR tinygo-org#123
|
Rebased and merged in #243 . Sorry for forgetting about this 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
ServiceData()function toAdvertisementFieldswhich returns a map of service data, similar to manufacturer data.I don't know the Bluetooth spec enough to understand the difference between these two, but I have different BLE devices and some advertise the data I'm interested in as service data, while others use manufacturer data. I'd like to use this library to handle both types of devices.
I have tested this on Linux and macOS. Both works, but as IIRC you can't get hold of the device MAC on macOS, I couldn't verify the data completely. I don't have access to Windows or custom devices to test further.
Hope this feature makes sense!