-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update generate-envrc.sh #215
Update generate-envrc.sh #215
Conversation
Hi @fransvanberckel, |
Hi @parauliya, |
Hi @fransvanberckel
There is a issue of extra space you have added in your code because of which code formatting has been changed because of which ci-checks are failing. |
Change spaces for tab's.
@Mergifyio refresh A-ha, i used spaces, and the creator tab's |
@fransvanberckel is not allowed to run commands |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Executing setup.sh does warning ...
WARNING: The TINKERBELL_TINK_PASSWORD variable is not set. Defaulting to a blank string.
WARNING: The TINKERBELL_TINK_USERNAME variable is not set. Defaulting to a blank string.
Doesn't generate-envrc.sh create these settings?
Doing a grep inside the tink repo root does.
root@deblnxsrv2:/var/tinkerbell/tink# grep -r TINKERBELL_TINK
deploy/docker-compose.yml: TINK_AUTH_USERNAME: ${TINKERBELL_TINK_USERNAME}
deploy/docker-compose.yml: TINK_AUTH_PASSWORD: ${TINKERBELL_TINK_PASSWORD}