Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generate-envrc.sh #215

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Update generate-envrc.sh #215

merged 2 commits into from
Jul 14, 2020

Conversation

fransvanberckel
Copy link
Contributor

@fransvanberckel fransvanberckel commented Jul 11, 2020

Executing setup.sh does warning ...

WARNING: The TINKERBELL_TINK_PASSWORD variable is not set. Defaulting to a blank string.
WARNING: The TINKERBELL_TINK_USERNAME variable is not set. Defaulting to a blank string.

Doesn't generate-envrc.sh create these settings?
Doing a grep inside the tink repo root does.

root@deblnxsrv2:/var/tinkerbell/tink# grep -r TINKERBELL_TINK

deploy/docker-compose.yml: TINK_AUTH_USERNAME: ${TINKERBELL_TINK_USERNAME}
deploy/docker-compose.yml: TINK_AUTH_PASSWORD: ${TINKERBELL_TINK_PASSWORD}

@fransvanberckel
Copy link
Contributor Author

fransvanberckel commented Jul 11, 2020

Okay found the cause, why this came up now, and not before. It's PR #64 and more specifically commit bc1a5a9

@parauliya
Copy link
Contributor

Hi @fransvanberckel,
Could you please check why your CI is failing and fix it?

@fransvanberckel
Copy link
Contributor Author

Hi @parauliya,
I am new, really don't know how ci-checks work, how to setup ci and how to solve the issue.

@parauliya
Copy link
Contributor

Hi @fransvanberckel
Did you go through the ci-checks details and check why it is failing?
There is a proper diff mentioned there that you need to fix in your code.

-        local tink_password
-        tink_password=$(generate_password)
+	local tink_password
+	tink_password=$(generate_password)

There is a issue of extra space you have added in your code because of which code formatting has been changed because of which ci-checks are failing.
Please do the required modification and push the code again.

Change spaces for tab's.
@fransvanberckel
Copy link
Contributor Author

fransvanberckel commented Jul 14, 2020

@Mergifyio refresh A-ha, i used spaces, and the creator tab's

@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2020

@fransvanberckel is not allowed to run commands

@parauliya parauliya requested a review from gauravgahlot July 14, 2020 11:25
@gauravgahlot gauravgahlot linked an issue Jul 14, 2020 that may be closed by this pull request
Copy link
Contributor

@gauravgahlot gauravgahlot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gauravgahlot gauravgahlot added the area/setup Issue related to tinkerbell setup label Jul 14, 2020
@gauravgahlot gauravgahlot added the ready-to-merge Signal to Mergify to merge the PR. label Jul 14, 2020
@mergify mergify bot merged commit 0100e53 into tinkerbell:master Jul 14, 2020
@fransvanberckel fransvanberckel deleted the tink-username-and-password branch July 14, 2020 14:52
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/setup Issue related to tinkerbell setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate-envrc.sh: tinkerbel tink username and password
4 participants