Skip to content

Commit

Permalink
Rename error script in go_cross_binary (bazelbuild#3481)
Browse files Browse the repository at this point in the history
It confused users that this rule always created a file called `error`.
  • Loading branch information
fmeum authored and jacqueline.lee committed Jul 19, 2023
1 parent 7738dde commit 09a951d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions go/private/rules/cross.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ def _error_script(ctx):
ctx.attr.target.label,
)
if _is_windows(ctx):
error_script = ctx.actions.declare_file("error.bat")
error_script = ctx.actions.declare_file("fake_executable_for_bazel_run.bat")
ctx.actions.write(error_script, WINDOWS_ERR_SCRIPT.format(errmsg), is_executable = True)
return error_script

error_script = ctx.actions.declare_file("error")
error_script = ctx.actions.declare_file("fake_executable_for_bazel_run")
ctx.actions.write(error_script, UNIX_ERR_SCRIPT.format(errmsg), is_executable = True)
return error_script

Expand Down

0 comments on commit 09a951d

Please sign in to comment.