Idea: Fix dependency resolution of platform dependencies #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JavaScript and native dependencies were ignored because the two parameters `platformVersion` and `compilerVersion` had been mixed up. Add a `require()` to `resolveSubset()` in order to enforce that a valid set of dependencies is passed.
tindzk
force-pushed
the
bug/idea-platform-deps
branch
from
b3be144 to
bbf0d70
Compare
tindzk
added a commit
that referenced
this pull request
Jan 27, 2019
Pull request #6 uncovered a problem in `ArtefactResolution`: When a test module does not set any target platforms, its dependencies would not be resolved.
tindzk
added a commit
that referenced
this pull request
Jan 27, 2019
Pull request #6 uncovered a problem in `ArtefactResolution`: When a test module did not set any target platforms, its dependencies would not be resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript and native dependencies were ignored because the two parameters
platformVersionandcompilerVersionhad been mixed up.Add a
require()toresolveSubset()in order to enforce that a valid set of dependencies is passed.