Bloop: Fix output path of submodules #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tindzk
force-pushed
the
bug/submodule-output-path
branch
from
44f11d4 to
c28e5ae
Compare
Currently, the output path of a submodule includes the relative path to its build file, although it should only be relative to the root project's build path. Another limitation that these changes address is that the output folder was not created by Seed such that Bloop might fail to link the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the output path of a submodule includes the relative path
to its build file, although it should only be relative to the root
project's build path.
Another limitation that these changes address is that the output
folder was not created by Seed such that Bloop might fail to link
the project.