Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create: Tests #3

Closed
5 of 7 tasks
timwis opened this issue Nov 19, 2015 · 3 comments
Closed
5 of 7 tasks

Create: Tests #3

timwis opened this issue Nov 19, 2015 · 3 comments

Comments

@timwis
Copy link
Owner

timwis commented Nov 19, 2015

  • create()
    • construct payload
    • return unmodified response
    • reformat columns (later)
  • set_public()
    • construct url (even with hairy resource param)
    • empty response but 200 status code
  • publish()
    • construct url (even with hairy resource param)
    • return unmodified response
timwis added a commit that referenced this issue Nov 20, 2015
@timwis
Add test for create() #3
abb27ca
@timwis
Copy link
Owner Author

timwis commented Nov 20, 2015

Having trouble capturing adapter.request_history[0].qs for set_public() - it's giving me an empty {}

@timwis
Copy link
Owner Author

timwis commented Nov 21, 2015

That trouble may well be an issue with the requests_mock library. Reported

timwis added a commit that referenced this issue Nov 21, 2015
@timwis
Use http for mock protocol, add test for set_public(). #3
f09be89
@timwis
Copy link
Owner Author

timwis commented Nov 22, 2015

Just realized URI construction is tested by virtue of the mock request matching

@timwis timwis closed this as completed Nov 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timwis