trace: add OpenTelemetry backend, deprecate OpenTracing#5
Closed
timvaillancourt wants to merge 1 commit intomainfrom
Closed
trace: add OpenTelemetry backend, deprecate OpenTracing#5timvaillancourt wants to merge 1 commit intomainfrom
timvaillancourt wants to merge 1 commit intomainfrom
Conversation
Add a new `opentelemetry` tracing backend that exports traces via OTLP/gRPC, sitting alongside the existing `opentracing-jaeger` and `opentracing-datadog` backends for one release cycle. The OpenTracing-based backends are deprecated in v24 and will be removed in v25. Both now log a deprecation warning at startup. The shared `--tracing-sampling-rate` flag is moved to trace.go so all backends can reference it without duplicate registration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this?
Adds a new
--tracer opentelemetrybackend that exports traces via OTLP/gRPC, and deprecates the existingopentracing-jaegerandopentracing-datadogbackends.How it works
otelTracingServiceimplements the existingtracingServiceinterface using the OpenTelemetry SDKotelgrpclibrary removed its interceptor API in v0.63.0, so we write thin wrappers)plugin_otel.goregisters the"opentelemetry"factory with OTLP/gRPC exporter, configurable via--otel-endpointand--otel-insecure--tracing-sampling-rateflag moves fromplugin_jaeger.gototrace.goso all backends can use itWhy not just replace?
Existing users of
--tracer opentracing-jaegeror--tracer opentracing-datadogneed time to migrate. Keeping both for one release avoids a breaking change. Thejaeger-client-golibrary is archived and the Jaeger project recommends migrating to OpenTelemetry.v25 cleanup
After the deprecation period, we can delete
opentracing.go,plugin_jaeger.go,plugin_datadog.go,logger.goand removeopentracing-go,opentracing-contrib/go-grpc,uber/jaeger-client-go, anddd-trace-go.v1from go.mod.vtadmin/grpcserver/server.goalso has direct OpenTracing usage that will need migrating.Most of this was written by Claude Code — I provided direction and design decisions.