fix(i18n): polish Russian desktop locale - #1
Merged
timoncool merged 5 commits intoJul 20, 2026
Conversation
Add behavior-based coverage for the Russian locale without pinning exact Russian wording: - normalizeLocale / isLocale / isSupportedLocaleValue / localeConfigValue for `ru` and the `ru-RU` and `ru_ru` aliases - I18nProvider restores a persisted Russian locale from display.language and saves the selected Russian locale back to config - runtime translator resolves the active Russian locale and falls back to English when a Russian key cannot be resolved Test-only change; no production code, ru.ts, or other translations touched.
This was referenced Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a focused helper patch for NousResearch#66833, not another upstream RU Desktop PR.
defineFieldCopyshape;defineLocale()fallback behavior for future keys;This directly addresses every item in the automated review on upstream NousResearch#66833: untranslated visible copy, incorrect
count < 5plural handling/LatinP, and missing regression tests.Validation on the PR branch
npm run typecheck --workspace apps/desktop;npm run test:ui --workspace apps/desktop -- src/i18n/languages.test.ts src/i18n/runtime.test.ts src/i18n/context.test.tsx src/components/language-switcher.test.tsx src/i18n/ru.test.ts— 5 files / 37 tests passed;npm run lint --workspace apps/desktop— 0 errors (only pre-existing warnings outside this localization scope);npm run build --workspace apps/desktop;git diff --check;Current-main rebase check
I also applied this complete commit series to current upstream
main(614dc194e) in a clean validation worktree. It applied without conflicts. Currentmainhas one new English key since NousResearch#66833,settings.nav.billing; addingbilling: 'Оплата'produced 2304 / 2304 explicit parity, and typecheck, the 37-test slice, lint (0 errors), and the production build all passed.After this helper is merged, the remaining mechanical step for NousResearch#66833 is therefore a rebase onto current
mainplus that onebillingentry.