This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Added new iPhone XR/XS Max screen width and height #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timomeh
suggested changes
Oct 8, 2018
lib/utils/device.js
Outdated
| @@ -2,6 +2,8 @@ import { Dimensions, Platform } from 'react-native' | |||
|
|
|||
| const IPHONE_X_WIDTH = 375 | |||
| const IPHONE_X_HEIGHT = 812 | |||
| const IPHONE_XR_XSMAX_WIDTH = 414; | |||
There was a problem hiding this comment.
Could you please remove the semicolons in line 5 and 6? This way we have a consistent code style everywhere.
|
Ignore the failing codeclimate check. Codeclimate is a bit too picky here imo |
|
Removed semicolons on last commit 👍 |
timomeh
approved these changes
Oct 8, 2018
|
Thank you very much! I'll make a release later this day. |
|
Thank you for this awesome work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new 2018 iPhones screen size in order to be taken into account when checking if device 'isIPhoneX'.
Before changes
After changes