Make Cthulhu.jl a weakdep, implement CthulhuExt.jl #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aviatesk, could you please look this over? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #381 +/- ##
==========================================
+ Coverage 78.96% 85.72% +6.75%
==========================================
Files 17 17
Lines 2054 2179 +125
==========================================
+ Hits 1622 1868 +246
+ Misses 432 311 -121 ☔ View full report in Codecov by Sentry. |
aviatesk
reviewed
Apr 15, 2024
aviatesk
reviewed
Apr 15, 2024
There was a problem hiding this comment.
snoopi_deep_analysis.md and snoopr.md contain documentation on using Cthulhu.ascend for analysis. However with this PR ascend will not be available when loading SnoopCompile only. Could you update these documents to reflect this change? We also need to remove the export of ascend too.
|
I fixed the documentation and |
|
Awesome, thanks! |
|
xref #382 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #376 for Cthulhu.jl after #379