Fix #470

[samanklesaria]

Line 822 of Revise.jl calls FileWatching.watch_folder. It then calls ret.changed on the result. But FileWatching.watch_folder returns a pair:

julia> FileWatching.watch_folder("src")
"extra.jl" => FileWatching.FileEvent(false, true, false)

As the documentation says:

The returned value is an pair where the first field is the name of the changed file (if available) and the second field is an object with boolean fields changed, renamed, and timedout, giving the event.

[timholy]

Thank for the PR!

The docstring of entr doesn't claim to support directories, though obviously the code has been prepared to do so. It looks like none of the tests check this case, though.

I'm good with this change, though a directory test would make it even better. CC @mlhetland, since he's kind of the de facto expert on entr.

[timholy]

Suggested change

	ret = watch_File(file, 1)
	ret = watch_file(file, 1)

[mlhetland]

CC @mlhetland, since he's kind of the de facto expert on entr.

Heh, more a fan than an expert, but thanks :-) Seems like a good idea to me. (The original entr also has the ability to watch directories. It requires a specific flag, -d, but I see no need for that in our case, really, as we'll be pretty explicit about supplying the directory name, anyway?)

[samanklesaria]

I updated the docstrings, and I'm happy to add a test too. Is there any way to run a subset of tests in the suite, rather than of all of them (as in Pkg.test)?

[timholy]

Sorry for the delay, I have been very distracted lately. Yes, you can run a subset of tests:

• julia 1.3 or higher: Pkg.test("Revise", test_args=["Method deletion"]) (you can add more than one testset)
• from the shell prompt, if you have all test dependencies in your environment: julia runtests.jl "Method deletion"
• from an interactive session: push!(ARGS, "Method deletion"); include("runtests.jl")

[ffevotte]

Just to tidy things up and let everyone interested know:

• @bogiebro: Bug in entr call to watch_folder #470 should be fixed, now that Allow entr to watch directories (fixes #470) #500 has been merged. Thanks for getting this started!
• @timholy: I think this PR could be closed now