-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support type redefinition (WIP) #25
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
- Coverage 74.8% 65.78% -9.03%
==========================================
Files 1 1
Lines 258 301 +43
==========================================
+ Hits 193 198 +5
- Misses 65 103 +38
Continue to review full report at Codecov.
|
Is there anything blocking this? |
Um, yes. In the OP I linked to a Julia PR for which @vtjnash points out significant problems. AFAIK those barriers remain. |
Sorry, I feel silly, I actually posted that question on the wrong PR! Nevermind! |
No problem! I'd like this to work too. I'm confident we'll get there eventually, but it's difficult work and there still remains quite a lot of low-hanging fruit. |
Bump Project.toml version in preparation for trying a new release
Any updates on this? |
Nope. Anyone interested in tackling it might take pointers from https://discourse.julialang.org/t/manually-reloading-a-module-in-1-1/25572/11?u=tim.holy. |
This is work towards supporting redefinition of types. It relies on JuliaLang/julia#22721, so it will only be available on 0.7 and higher. AFAICT the only missing part is to populate method2rex. (It would be nicer if we could just get the source-expression directly from the
Method
, but currently that's not cached.)