Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support type redefinition (WIP) #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

timholy
Copy link
Owner

@timholy timholy commented Jul 15, 2017

This is work towards supporting redefinition of types. It relies on JuliaLang/julia#22721, so it will only be available on 0.7 and higher. AFAICT the only missing part is to populate method2rex. (It would be nicer if we could just get the source-expression directly from the Method, but currently that's not cached.)

@codecov-io
Copy link

Codecov Report

Merging #25 into master will decrease coverage by 9.02%.
The diff coverage is 22.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage    74.8%   65.78%   -9.03%     
==========================================
  Files           1        1              
  Lines         258      301      +43     
==========================================
+ Hits          193      198       +5     
- Misses         65      103      +38
Impacted Files Coverage Δ
src/Revise.jl 65.78% <22.91%> (-9.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1dcb96...89e9104. Read the comment docs.

@ExpandingMan
Copy link

Is there anything blocking this?

@timholy
Copy link
Owner Author

timholy commented Sep 13, 2018

Is there anything blocking this?

Um, yes. In the OP I linked to a Julia PR for which @vtjnash points out significant problems. AFAIK those barriers remain.

@ExpandingMan
Copy link

Sorry, I feel silly, I actually posted that question on the wrong PR! Nevermind!

@timholy
Copy link
Owner Author

timholy commented Sep 13, 2018

No problem! I'd like this to work too. I'm confident we'll get there eventually, but it's difficult work and there still remains quite a lot of low-hanging fruit.

oschulz pushed a commit to oschulz/Revise.jl that referenced this pull request Nov 20, 2018
Bump Project.toml version in preparation for trying a new release
@Nosferican
Copy link

Any updates on this?

@timholy
Copy link
Owner Author

timholy commented Aug 21, 2019

Nope. Anyone interested in tackling it might take pointers from https://discourse.julialang.org/t/manually-reloading-a-module-in-1-1/25572/11?u=tim.holy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants