Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two small bugs in entr #494

Closed
ffevotte opened this issue May 26, 2020 · 0 comments · Fixed by #496
Closed

Two small bugs in entr #494

ffevotte opened this issue May 26, 2020 · 0 comments · Fixed by #496

Comments

@ffevotte
Copy link
Collaborator

While trying to fix the tests for #470, I uncovered what I think are two small bugs in the new implementation of entr:

  1. callbacks are not removed in all cases after entr ended, especially in cases where the user-provided callback throws an error
  2. I think clusters of modifications tend to trigger user callback multiple times

A fix is provided in f6461b5. Hopefully, it should land in a branch that provides a good and reliable test for entr. I'm only opening this issue to avoid forgetting to include this elsewhere in case I would not manage to fix tests for entr...
ffevotte added a commit to ffevotte/Revise.jl that referenced this issue May 27, 2020
@ffevotte
Fix timholy#494 & improve entr tests
6db2e86 
Check that `entr`:
1. behaves well in cases of clustered events -> OK
2. correctly removes user callbacks even when they throw -> small fix provided

Closes: timholy#494
This was referenced May 27, 2020
Merged
Closed
timholy pushed a commit that referenced this issue May 29, 2020
@ffevotte
Fix #494 & improve entr tests (#496)
37065db 
Check that `entr`:
1. behaves well in cases of clustered events -> OK
2. correctly removes user callbacks even when they throw -> small fix provided

Closes: #494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #494 & improve entr tests ffevotte/Revise.jl
1 participant
@ffevotte