-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for using @showprogress on Threads.@threads for loops #284
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #284 +/- ##
==========================================
+ Coverage 96.81% 97.03% +0.22%
==========================================
Files 1 1
Lines 533 539 +6
==========================================
+ Hits 516 523 +7
+ Misses 17 16 -1 ☔ View full report in Codecov by Sentry. |
My bad, I never tested on older versions of Julia. The Threads.@threads had a different expression tree before v1.3.0-rc1 and so the new test I added was failing on older builds. I'll gate the Threads.@threads test behind a |
Take three. I updated to fix the code coverage errors. The last run failed on the nightly ubuntu-latest build because the test case "test_threads.jl ProgressUnknown" errored out. I'm not sure why. That test should not touch any of the code in this pr. I can't repro it, and it didn't fail in the first run (https://github.com/timholy/ProgressMeter.jl/actions/runs/6859117251/job/18660114093?pr=284). Is the test flaky on master? |
Recently yes |
Okay, afaict this passes everything except for the flaky test. Should be good to go, but let me know if there's anything else I should look into. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
support for @Threads.threads
is very welcome!
LGTM |
This lets you use the @showprogress macro on parallel for loops. For example,