Skip to content

fix: allow static assets through wsist.ch middleware - #37

Merged
timh8127 merged 1 commit into
mainfrom
fix/wsist-landing-static-assets
Jun 28, 2026
Merged

fix: allow static assets through wsist.ch middleware#37
timh8127 merged 1 commit into
mainfrom
fix/wsist-landing-static-assets

Conversation

@timh8127

@timh8127 timh8127 commented Jun 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • Expands the allowedOnMarketing path list in the wsist.ch middleware block to include static asset prefixes (/_framework, /_content, /_blazor, /app.css, /landing.css, /landing.js, /logo.svg, /favicon, /WSIST.Web.styles.css)
  • Fixes blank page at wsist.ch/ caused by the middleware redirecting JS/CSS requests back to / instead of serving them
  • Also updates global.json SDK version to match the locally installed 10.0.109 SDK

Test plan

  • dotnet test — 35 tests pass
  • dotnet csharpier format . — no formatting changes needed
  • Visit wsist.ch/ and confirm the landing page loads with no console errors
  • Verify wsist.ch/login-page still loads correctly
  • Verify authenticated users on app.wsist.ch are unaffected

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Improved handling of site assets so images, styles, scripts, and framework files can load correctly instead of being redirected.
    • Visitors to marketing-site pages should now see the site render more reliably, including Blazor-related and static resources.
  • Chores

    • Updated the .NET SDK version used by the project.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 20525d3d-33d8-40d2-8aee-4e5fbe675620

📥 Commits

Reviewing files that changed from the base of the PR and between 214f6f8 and ee9ed57.

📒 Files selected for processing (2)
  • WSIST/WSIST.Web/Program.cs
  • WSIST/global.json

📝 Walkthrough

Walkthrough

The marketing-site middleware in Program.cs has its allowedOnMarketing path list expanded with Blazor framework and static asset routes. The .NET SDK version in global.json is changed from 10.0.201 to 10.0.109.

Marketing Site & SDK Changes

Layer / File(s) Summary
Marketing middleware allowlist + SDK version
WSIST/WSIST.Web/Program.cs, WSIST/global.json
Adds /_framework, /_content, /_blazor, /app.css, /landing.css, /landing.js, /logo.svg, /favicon, and /WSIST.Web.styles.css to the allowedOnMarketing list so these assets bypass the redirect; downgrades SDK version to 10.0.109.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 Hop hop, the assets now flow free,
No more redirects blocking CSS with glee!
The favicon winks, the logo shines bright,
Blazor's framework paths are set just right.
SDK trimmed down, a smaller version today ~

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: allowing static assets through the wsist.ch middleware.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/wsist-landing-static-assets

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@timh8127
timh8127 merged commit 121633d into main Jun 28, 2026
2 checks passed
@timh8127
timh8127 deleted the fix/wsist-landing-static-assets branch June 28, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant