feat: phase 4 - reminders, post-study feedback, grade trends, weekly planner - #25
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds date-anchored scoring and a 7-day weekly planner to PriorityCalculator; Home shows missing-grade reminders and SVG grade trends; Study page gains Today/This-week modes, studied-test feedback, per-day hour inputs, and a weekly plan view powered by the new planner. ChangesStudy Planning and Grade Tracking
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@WSIST/WSIST.Engine/PriorityCalculator.cs`:
- Around line 96-110: GetWeeklyPlan builds the 7-day plan using
GetStudyRecommendations but GetStudyRecommendations currently uses
DateTime.Today as its reference (causing tests to be considered relative to
today rather than each iterated date), so change GetStudyRecommendations to
accept a reference date parameter (e.g., DateOnly referenceDate) and update its
internal filtering/scoring to use that referenceDate instead of DateTime.Today;
then call GetStudyRecommendations(allTests, hours, date) from GetWeeklyPlan
(where date is the loop variable) so each day's recommendations are computed
relative to that day.
In `@WSIST/WSIST.Web/Components/Pages/Study.razor.cs`:
- Around line 75-90: After reloading allTests in SaveStudiedUnderstanding,
invalidate or recompute the weeklyPlan so the UI doesn't show stale weekly rows:
after allTests = management.LoadAllTests(CurrentUserId) call the existing weekly
planner recompute (e.g. weeklyPlan = weeklyPlanner.CalculateWeeklyPlan(allTests,
/*hours/dates*/ ) or set weeklyPlan = null and invoke the method that builds it
(or call RecalculateWeeklyPlan()) so weeklyPlan reflects the updated data before
StateHasChanged(); reference SaveStudiedUnderstanding, management.TestEditor,
LoadAllTests, weeklyPlan, and StateHasChanged in the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 544ce4b5-f8b5-4f14-93d6-c9b3078be082
📒 Files selected for processing (6)
WSIST/WSIST.Engine/PriorityCalculator.csWSIST/WSIST.Web/Components/Pages/Home.razorWSIST/WSIST.Web/Components/Pages/Home.razor.csWSIST/WSIST.Web/Components/Pages/Study.razorWSIST/WSIST.Web/Components/Pages/Study.razor.csWSIST/WSIST.Web/wwwroot/app.css
…stale weekly plan after study feedback Addresses CodeRabbit review on PR #25: - GetStudyRecommendations/CalculateTotalScore/CalculateUrgencyScore accept an optional asOfDate so GetWeeklyPlan scores and filters each day relative to that day instead of today - weekly plan rows display per-day scores - SaveStudiedUnderstanding recomputes the weekly plan when one is shown Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
Implements all four Phase 4 features from
wsist-phase4-tasks.md:PriorityCalculator.GetWeeklyPlan.Notes
@using WSIST.EnginetoStudy.razor(required by the new markup referencingTestenums).GetGradeClasstoStudy.razor.cs(weekly plan rows use it; it previously existed only on Home).dotnet buildran clean (0 errors) before each commit.🤖 Generated with Claude Code
Summary by CodeRabbit