Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poc rename symbol tg #1

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Poc rename symbol tg #1

wants to merge 11 commits into from

Commits on Feb 11, 2022

  1. POC for "rename" functionality 

    LSPs can offer a rename capability to rename a "symbol" across a workspace.
We're not there yet, but this is a starting point. In VS Code it can be used by
right clicking a symbol (currently variable or call to local function) and
selecting "Rename symbol". A dialog should pop up asking for a new name.

Official spec:
https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_rename
    @Tuxified
    Tuxified committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    8945480 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Fix renaming functions with multiple headers

    @timgent
    timgent committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    2e76985 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Simplify tests with rename_example 

    - Make rename_example a `.ex` file so we can later test multi-file
  refactors
- Simplify rename_example to make it easier to follow
- Extract some common patterns out in the tests
    @timgent
    timgent committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    1daf1c8 View commit details
    Browse the repository at this point in the history

  2. Implement rename across multiple files

    @timgent
    timgent committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    987456e View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Fix rename file version & file paths

    @timgent
    timgent committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    4171632 View commit details
    Browse the repository at this point in the history

  2. Fix rename issue with duplicate entries when renaming var definition

    @timgent
    timgent committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    0df0996 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2022

  1. Tests for rename prepare and fix rename prepare across multiple files

    @timgent
    timgent committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    42c4d30 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into poc_rename_symbol_tg

    @timgent
    timgent committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    716de9d View commit details
    Browse the repository at this point in the history

  3. Fix rename issues following merge with master

    @timgent
    timgent committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    faf8d25 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Rename to only rename fn headers of correct arity

    @timgent
    timgent committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    fab2032 View commit details
    Browse the repository at this point in the history

  2. Simplify get_char_ident fn in rename provider

    @timgent
    timgent committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    532bf88 View commit details
    Browse the repository at this point in the history