Fix issues with CI tests #6586
Merged
Fix issues with CI tests #6586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6586 +/- ##
==========================================
+ Coverage 79.78% 79.83% +0.05%
==========================================
Files 190 190
Lines 37281 37235 -46
Branches 9457 9440 -17
==========================================
- Hits 29746 29728 -18
+ Misses 3132 3120 -12
+ Partials 4403 4387 -16 ☔ View full report in Codecov by Sentry. |
|
@antekresic, @mahipv: please review this pull request.
|
|
For reference actions/runner#2906 |
mkindahl
force-pushed
the
fix-node20-runners
branch
from
33a643a
to
735a368
Compare
akuzm
approved these changes
Feb 1, 2024
jnidzwetzki
approved these changes
Feb 1, 2024
mkindahl
force-pushed
the
fix-node20-runners
branch
from
aceefd3
to
6f1859a
Compare
mkindahl
force-pushed
the
fix-node20-runners
branch
from
6f1859a
to
a16fffe
Compare
mkindahl
force-pushed
the
fix-node20-runners
branch
from
a16fffe
to
94481f8
Compare
Also fix a version tag
The names were not unique so two different jobs could have the same name for the upload artifact.
Upload artifact name was using a matrix field that did not exist, causing a duplicate upload artifact name.
mkindahl
force-pushed
the
fix-node20-runners
branch
from
94481f8
to
047eb20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issues, each as a separate commit:
Fix upload artifact names for Windows builds
Fix upload names for ABI tests
The names were not unique so two different jobs could have the same name for the upload artifact.
Use checkout@v3 for centos7
Update cache and download actions to node20
Disable-check: force-changelog-file, commit-count