-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support rollup and integer states state/timeline aggs #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syvb
force-pushed
the
sv/state_agg-rollup
branch
from
November 29, 2022 14:25
9d0ed0f
to
41ff3dd
Compare
syvb
force-pushed
the
sv/state_agg-rollup
branch
2 times, most recently
from
November 30, 2022 20:18
8171f41
to
1e97905
Compare
syvb
changed the title
Support rolling up state/timeline aggs
Support rollup and integer states state/timeline aggs
Dec 1, 2022
syvb
force-pushed
the
sv/state_agg-rollup
branch
from
December 1, 2022 20:11
4832e02
to
eda09f5
Compare
Merged
WireBaron
reviewed
Dec 5, 2022
syvb
force-pushed
the
sv/state_agg-rollup
branch
2 times, most recently
from
December 6, 2022 00:59
d2e6721
to
ad5fd1d
Compare
WireBaron
approved these changes
Dec 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the inputs to the trans function all below to the aggregate context so shouldn't need to be cloned.
syvb
force-pushed
the
sv/state_agg-more
branch
from
December 6, 2022 14:53
4997c37
to
327e22e
Compare
syvb
force-pushed
the
sv/state_agg-rollup
branch
2 times, most recently
from
December 6, 2022 19:06
1aa764b
to
0e06731
Compare
epgts
approved these changes
Dec 6, 2022
syvb
force-pushed
the
sv/state_agg-more
branch
from
December 6, 2022 21:53
327e22e
to
33dc255
Compare
syvb
force-pushed
the
sv/state_agg-rollup
branch
from
December 6, 2022 21:58
0e06731
to
9aaeb3c
Compare
Signed-off-by: Smittyvb <[email protected]>
syvb
force-pushed
the
sv/state_agg-rollup
branch
from
December 6, 2022 22:06
9aaeb3c
to
35b1fe3
Compare
bors r+ |
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rollup
forstate_agg
andtimeline_agg
.state_agg
andtimeline_agg
. An aggregate can have integer states or string states, but not both. For a few functions this would mean having two functions with the same argument types but differing return types, so in that case I made a separate function for integer-valued aggregates (e.g.state_int_timeline
).Ideally this should have been two separate PRs, but my changes to
rollup
and the rest of thestate_agg
code have become intertwined.(this should be merged after #636)