Relax tolerance in UDDSketch merge assertions #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests passed locally, but perhaps I should take this to indicate that I need to reduce the size of |
rtwalker
force-pushed
the
rw/uddsketch-failed-assert
branch
from
4b1c835
to
1ce4ae0
Compare
epgts
reviewed
Jun 7, 2022
|
Dropped the test I'd added, since using the full dataset from #396 proved to be too large for CI. The test did pass locally, but I'm not sure getting a minimally reproducible example is a priority at the moment. Haven't been able to trigger the error (after 100+ queries) since this change. |
f64::EPSILON was proving to be too tight of a tolerance for this assertion. Since we are trying to recompute the initial error parameter from the current number of compactions, we need to be more forgiving with the floating point calcuations involved.
rtwalker
force-pushed
the
rw/uddsketch-failed-assert
branch
from
1ce4ae0
to
6a82b0e
Compare
epgts
approved these changes
Jun 7, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #396 by increasing the tolerance in our comparison of the calculated initial error parameters for two
UDDSketchesbeing merged