Handle NULL output from our aggregates #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pgx::Internal` is inconsistent in that a NULL input to a function taking `Internal` works fine and results in an `Internal` containing `None` while returning an Internal containing `None` results in an error. This commit works around the issue by making our functions return an `Option<Internal>` if they can return a SQL NULL. fixes issue #362
epgts
approved these changes
Mar 30, 2022
WireBaron
approved these changes
Mar 30, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pgx::Internalis inconsistent in that a NULL input to a function takingInternalworks fine and results in anInternalcontainingNonewhile returning an Internal containingNoneresults in an error. This commit works around the issue by making our functions return anOption<Internal>if they can return a SQL NULL.fixes #362