-
Notifications
You must be signed in to change notification settings - Fork 168
Add telemetry event for Jaeger gRPC remote storage writer #1548
Comments
@VineethReddy02 We already have telemetry event around otel ingestion and #1535 is implemented on top of otel. Hence all the events which we send for otel ingestion is also applicable for Jaeger ingestion. Do we need any additional signal from the product perspective? |
I agree with your point Arun, But we need to know if the user is using Otel or Jaeger ingestion endpoints or both? And rest all we can see from Otel-specific telemetry that has already been captured. Maybe it's a good idea to change telemetry keys from |
I've been exploring following options to enable telemetry,
Option 1 and Option 2 requires code changes in promscale and extension, but 3 requires change only in extension. |
This commit adds a telemetry event to find whether jaeger spans are ingested into promscale or not. Fixes timescale/promscale#1548 Signed-off-by: Arunprasad Rajkumar <[email protected]>
This commit adds a telemetry event named `promscale_traces_jaeger_span_types` to find types of jaeger spans ingested into promscale. Fixes timescale/promscale#1548 Signed-off-by: Arunprasad Rajkumar <[email protected]>
This commit adds a telemetry event named `promscale_traces_jaeger_span_types` to find types of jaeger spans ingested into promscale. Fixes timescale/promscale#1548 Signed-off-by: Arunprasad Rajkumar <[email protected]>
This commit adds a telemetry event named `promscale_traces_jaeger_span_types` to find types of jaeger spans ingested into promscale. Fixes timescale/promscale#1548 Signed-off-by: Arunprasad Rajkumar <[email protected]>
This commit adds a telemetry event named `promscale_traces_jaeger_span_types` to find types of jaeger spans ingested into promscale. According to [1], Trace spans processed by Jaeger collector will have an internal attribute named 'internal.span.format' with one of the values 'jaeger|zipkin|proto|otlp|unknown'[2]. We can use this to infer whether promscale's gRPC remote storage implementation has been used or not. [1] jaegertracing/jaeger#1490 [2] https://github.com/jaegertracing/jaeger/blob/b7088238c017e5a54896efbf5ed38959e885e0c5/cmd/collector/app/processor/interface.go#L56-L67 Fixes timescale/promscale#1548 Signed-off-by: Arunprasad Rajkumar <[email protected]>
This commit adds a telemetry event named `promscale_traces_jaeger_span_types` to find types of jaeger spans ingested into promscale. According to [1], Trace spans processed by Jaeger collector will have an internal attribute named 'internal.span.format' with one of the values 'jaeger|zipkin|proto|otlp|unknown'[2]. We can use this to infer whether promscale's gRPC remote storage implementation has been used or not. [1] jaegertracing/jaeger#1490 [2] https://github.com/jaegertracing/jaeger/blob/b7088238c017e5a54896efbf5ed38959e885e0c5/cmd/collector/app/processor/interface.go#L56-L67 Fixes timescale/promscale#1548 Signed-off-by: Arunprasad Rajkumar <[email protected]>
Relates to #1535
The text was updated successfully, but these errors were encountered: