Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support pg13, pg14 as pgvector does #94

Merged
merged 10 commits into from
Oct 3, 2024
Merged

Conversation

yihong0618
Copy link
Contributor

This PR try to support pg12-pg14 as pgvector supports. some of the codes from zombodb

close: #93

This PR try to support pg12-pg14 as pgvector supports.
some of the codes from zombodb

close: timescale#93
Signed-off-by: yihong0618 <[email protected]>
Co-authored-by: zombodb <[email protected]>
@yihong0618 yihong0618 requested a review from a team as a code owner June 13, 2024 11:52
@CLAassistant
Copy link

CLAassistant commented Jun 13, 2024

CLA assistant check
All committers have signed the CLA.

@cevian
Copy link
Collaborator

cevian commented Jun 14, 2024

@yihong0618 thanks. I'll review this.

@nickcanz
Copy link

nickcanz commented Jul 5, 2024

👋 Just 👍 this PR as having the same version support as pgvector would be very helpful for our use cases, we primarily use pg14 right now.

@syvb
Copy link
Member

syvb commented Sep 30, 2024

Could you remove PG12 support? I don't think it's worth it to add complexity for a PG version that will be obsolete in 2 months.

@yihong0618
Copy link
Contributor Author

Could you remove PG12 support? I don't think it's worth it to add complexity for a PG version that will be obsolete in 2 months.

OK wil do it these days

@yihong0618 yihong0618 changed the title feat: support pg12, pg13, pg14 as pgvector does feat: support pg13, pg14 as pgvector does Oct 1, 2024
@yihong0618
Copy link
Contributor Author

@syvb @cevian Done

pgvectorscale/src/access_method/options.rs Outdated Show resolved Hide resolved
pgvectorscale/src/access_method/mod.rs Outdated Show resolved Hide resolved
pgvectorscale/src/access_method/build.rs Show resolved Hide resolved
@yihong0618 yihong0618 requested a review from syvb October 3, 2024 01:25
syvb
syvb previously approved these changes Oct 3, 2024
Copy link
Member

@syvb syvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: Matvey Arye <[email protected]>
Copy link
Collaborator

@cevian cevian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this change

@syvb syvb merged commit 659c100 into timescale:main Oct 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supported Postgres versions
5 participants