-
Notifications
You must be signed in to change notification settings - Fork 223
Fix 382 and 389 #390
base: main
Are you sure you want to change the base?
Fix 382 and 389 #390
Conversation
Sorry for slow reply, I left few comments. |
Hello @TobiasJacob I submitted a PR for adding GCS backups (#401), but our methods are slightly different. Perhaps we should coordinate an effort to enable and document both Azure and GCP backups in a way that's consistent? Or, if you'd like, you could make this PR focus on priority class and I can add Azure to my PR :) |
Hello @gunnarsundberg, yes I see, the configuration of Azure through secrets is probably a better approach. I think you have a better understanding of how to implement that, if you have a way to try out Azure it's probably better if you go ahead an implement it. I can create a new PR for the priority class part. |
"priorityClassName": { | ||
"minimum": 1, | ||
"type": [ | ||
"integer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be string, and there should be no "minimum"
Fix #382
Fix #389