Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Fix 382 and 389 #390

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

TobiasJacob
Copy link

Fix #382

  • Add a way to set the priority class. Helpful to prevent eviction of timescaledb in case of memory pressure.

Fix #389

  • The default values made setting up Azure backups after deployment complicated.
  • Added an example (with fake credentials) to give people an understanding of how to enable Azure backups.

@CLAassistant
Copy link

CLAassistant commented Jun 22, 2022

CLA assistant check
All committers have signed the CLA.

@paulfantom
Copy link
Contributor

Sorry for slow reply, I left few comments.

@gunnarsundberg
Copy link
Contributor

gunnarsundberg commented Jul 21, 2022

Hello @TobiasJacob I submitted a PR for adding GCS backups (#401), but our methods are slightly different. Perhaps we should coordinate an effort to enable and document both Azure and GCP backups in a way that's consistent? Or, if you'd like, you could make this PR focus on priority class and I can add Azure to my PR :)

@TobiasJacob
Copy link
Author

Hello @gunnarsundberg, yes I see, the configuration of Azure through secrets is probably a better approach. I think you have a better understanding of how to implement that, if you have a way to try out Azure it's probably better if you go ahead an implement it. I can create a new PR for the priority class part.

"priorityClassName": {
"minimum": 1,
"type": [
"integer",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be string, and there should be no "minimum"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] Default values prevent setup of Azure backups Add a way to set priority class
5 participants