Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[timescaledb-single] Add tolerations to patroni config update job #307

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[timescaledb-single] Add tolerations to patroni config update job #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
214b14e
fix(timescaledb-single): add tolerations to patroni config update job
Art3mK Oct 8, 2021
776b750
Merge branch 'master' into job-tolerations
Art3mK Dec 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/timescaledb-single/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
apiVersion: v1
name: timescaledb-single
description: 'TimescaleDB HA Deployment.'
version: 0.10.0
version: 0.10.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you trying to update the chart version? This is up to the maintainers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not. We require chart update on each PR as mentioned in contributing doc - https://github.com/timescale/helm-charts/blob/main/CONTRIBUTING.md#technical-requirements

# appVersion specifies the version of the software, which can vary wildly,
# e.g. TimescaleDB 1.4.1 on PostgreSQL 11 or TimescaleDB 1.5.0 on PostgreSQL 12.
# https://github.com/helm/helm/blob/master/docs/charts.md#the-appversion-field
Expand Down
4 changes: 4 additions & 0 deletions charts/timescaledb-single/templates/job-update-patroni.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ spec:
heritage: {{ .Release.Service }}
spec:
restartPolicy: OnFailure
{{- with .Values.tolerations }}
tolerations:
{{ toYaml . | indent 8 }}
{{- end }}
Comment on lines +40 to +43
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{- with .Values.tolerations }}
tolerations:
{{ toYaml . | indent 8 }}
{{- end }}
tolerations:
{{ toYaml .Values.tolerations | nindent 8 }}

Copy link
Contributor

@agronholm agronholm Sep 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I think about it, what happens when the list is empty? Shouldn't this block be guarded against that?

containers:
- name: {{ template "timescaledb.fullname" . }}-patch-patroni-config
image: curlimages/curl
Expand Down