Repository navigation
π¨ Palette: Add pulsing heartbeat and color-blind accessible symbols to telemetry dashboard #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
616734a
c18bce4
43c9cbc
52fff4f
6c8a351
8dddcaf
401e87a
2f0316a
0004f1d
2368974
072448c
d87e193
ec8ca21
7bb1afc
6bce705
0e99c4a
d448417
058530a
66f4bd0
929e533
47dce42
5a48520
fa33979
b81fd6c
466eb04
638d52c
4efe05d
aa3c76c
05feceb
72454e6
a184075
6b309e5
084fd24
dacd792
86117e6
7ab3b2c
d7357f3
da1fc7c
aa2c7a5
70cc579
78daa64
bc96a2a
08b11b6
6150f37
53dce74
7d8be62
94e5f87
57d3c5a
189f11e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -92,14 +92,14 @@ jobs: | |
| const parentTitle = `PR #${prNumber} agent feedback rollup`; | ||
|
|
||
| const search = await linear( | ||
| `query($q: String!) { | ||
| issueSearch(query: $q, first: 5) { | ||
| `query($title: String!) { | ||
| issues(filter: { title: { eq: $title } }) { | ||
| nodes { id identifier title } | ||
| } | ||
| }`, | ||
| { q: `team:Termux-monorepo_linear title:"${parentTitle}"` } | ||
| { title: parentTitle } | ||
|
Comment on lines
+96
to
+101
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. π Info: New Linear query has no result limit The replaced query dropped the Was this helpful? React with π or π to provide feedback. |
||
| ); | ||
| let parentId = search.issueSearch?.nodes?.find( | ||
| let parentId = search.issues?.nodes?.find( | ||
|
Comment on lines
+96
to
+103
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. π Workflow change is unrelated to the PR's stated scope The PR description covers only dashboard UX/accessibility changes, but it also rewrites the Linear parent-issue lookup in the CI workflow. Unrelated CI/automation changes bundled into a UI PR make review and rollback harder; consider splitting it out or documenting the reason in the PR body. Was this helpful? React with π or π to provide feedback. |
||
| n => n.title === parentTitle | ||
| )?.id; | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,7 +47,16 @@ def make_dashboard(): | |
| # Header info | ||
| now_str = datetime.now().strftime("%Y-%m-%d %H:%M:%S") | ||
| header_text = Text() | ||
| header_text.append("β‘ TERMUX MULTI-AGENT PARALLEL TELEMETRY β‘\n", style="bold yellow") | ||
|
|
||
| # Pulsing active heartbeat indicator | ||
| is_even = int(time.time()) % 2 == 0 | ||
| heartbeat = "β" | ||
| heartbeat_style = "bold green" if is_even else "dim green" | ||
|
Comment on lines
+51
to
+54
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. π Info: Heartbeat pulse may appear frozen due to alignment of refresh interval with the 1-second toggle The heartbeat state is derived from Was this helpful? React with π or π to provide feedback. |
||
|
|
||
| header_text.append("β‘ TERMUX MULTI-AGENT PARALLEL TELEMETRY β‘ ", style="bold yellow") | ||
| header_text.append("[", style="dim") | ||
| header_text.append(heartbeat, style=heartbeat_style) | ||
| header_text.append(" LIVE]\n", style="dim") | ||
|
Comment on lines
+51
to
+59
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. π‘ Change lacks the required work-item reference demanded by repository process The dashboard change (heartbeat block added at Process rules in AGENTS.md that are unmetAGENTS.md hard rules require: "Do not invent work outside Prompt for agentsWas this helpful? React with π or π to provide feedback. |
||
| header_text.append(f"Last Sync: {now_str} | File: {TELEMETRY_LOG}", style="dim") | ||
|
|
||
| header_panel = Panel( | ||
|
|
@@ -110,15 +119,15 @@ def make_dashboard(): | |
| except ValueError: | ||
| pass | ||
|
|
||
| # Beautiful styled status tag | ||
| # Beautiful styled status tag with color-blind accessible symbols | ||
| if level == "SUCCESS": | ||
| status_str = Text("SUCCESS", style="bold green") | ||
| status_str = Text("β SUCCESS", style="bold green") | ||
| elif level == "RETRY": | ||
| status_str = Text("RETRYING", style="bold yellow") | ||
| status_str = Text("π RETRYING", style="bold yellow") | ||
| elif level == "CRITICAL": | ||
| status_str = Text("CRITICAL", style="bold red") | ||
| status_str = Text("π¨ CRITICAL", style="bold red") | ||
| else: | ||
| status_str = Text("PROCESSING", style="bold blue") | ||
| status_str = Text("β³ PROCESSING", style="bold blue") | ||
|
Comment on lines
+122
to
+130
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. π Info: Emoji status glyphs may render as double-width/tofu in some Termux terminals Prepending emoji to the status text changes the rendered width of the Status column. Rich computes widths using its own unicode width tables; terminals/fonts on Termux that lack emoji coverage or that treat these code points as narrow can cause column misalignment or replacement glyphs. If broad Termux terminal compatibility matters, ASCII-safe markers (e.g. Was this helpful? React with π or π to provide feedback. |
||
|
|
||
| table.add_row( | ||
| target, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π‘ Feedback rollup lookup no longer limited to the project's own team
The lookup for the existing rollup item drops the team restriction (
issues(filter: { title: { eq: $title } })at.github/workflows/agent-feedback-linear-sync.yml:95-100), so a same-titled item belonging to another team can be picked up and new review-feedback entries get filed under the wrong place.Impact: Bot review comments can be attached to an unrelated team's item, or the creation can fail outright, losing that feedback.
Cross-team title collision in the parent lookup
The previous query used
issueSearchwithteam:Termux-monorepo title:"...", scoping matches to the project's team. The newissues(filter: { title: { eq: $title } })matches any issue whose title equalsPR #<n> agent feedback rollupacross every team visible to the API key. Since titles only encode the PR number (not repo or team), a collision from another team/repo yields aparentIdoutsideteamId(.github/workflows/agent-feedback-linear-sync.yml:91), which is then used in the subtaskissueCreateat lines 144-172 β Linear rejects or misplaces sub-issues whose parent lives in a different team.Adding
team: { id: { eq: $teamId } }to the filter restores the original scoping.Was this helpful? React with π or π to provide feedback.