ci(peer): gate routed review on authorized interactive responses - #241
Merged
Merged
Conversation
Agent-Identity: Manus Task-Ref: interactive-peer-gate Signed-off-by: Manus <manus@manus.im>
|
Mention Blocks like a regular teammate with your question or request: @blocks review this pull request Run |
github-project-automation
Bot
moved this to Todo
in @timerloggedout-spec's untitled project team planning
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
context_key: pr-241-manusinteractive-peer-gate Feedback excerptInstructions
|
PR Summary by QodoGate second-pass review on SHA-bound peer responses
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Owner
Author
|
OPERATOR: PR #241 is based on current master Next: if peer collect succeeds and no required checks fail → merge via OPERATOR path. |
github-project-automation
Bot
moved this from Todo
to Done
in @timerloggedout-spec's untitled project team planning
Code Review by Qodo
1. Response runs cannot release gate
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+16
to
+19
| issue_comment: | ||
| types: [created, edited] | ||
| pull_request_review: | ||
| types: [submitted, edited, dismissed] |
There was a problem hiding this comment.
1. Response runs cannot release gate 🐞 Bug ≡ Correctness
Provider comments, reviews, and acknowledgements start orchestrator runs that can publish responses_collected, but gemini-after-peers rejects every workflow_run whose source event is not pull_request. These events also cancel the original PR-triggered run through shared concurrency, so the final response commonly leaves the second pass permanently blocked.
Agent Prompt
## Issue description
The orchestrator can become ready from comment or review events, but the downstream workflow only accepts pull-request-originated runs. Shared per-PR concurrency also cancels the original eligible run when those response events arrive.
## Issue Context
Ensure a successful run that ingests the final provider response can trigger the second pass while retaining same-repository, live-head, and authenticated-state validation.
## Fix Focus Areas
- .github/workflows/peer-review-orchestrator.yml[16-24]
- .github/workflows/gemini-after-peers.yml[16-20]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+198
to
+202
| const afterCycle = item => new Date(item.updated_at || item.submitted_at || item.created_at || 0).getTime() >= startedAt; | ||
| const sourceComments = [...evidence.comments, ...evidence.reviewComments]; | ||
| const comment = sourceComments.find(item => | ||
| providerFor(item.user?.login) === provider && afterCycle(item) && !isControlOnly(item.body) | ||
| ); |
There was a problem hiding this comment.
2. Historical comments satisfy new sha 🐞 Bug ≡ Correctness
deliveredProvider accepts provider comments using only updated_at against a baseline derived from the commit timestamp, without binding the comment to the current head. An old comment edited during the cycle—or one newer than an old authored/committed head—therefore completes the provider for a new SHA.
Agent Prompt
## Issue description
Historical provider comments can be accepted as completion for a new head because the predicate uses mutable comment timestamps and a commit-metadata baseline rather than evidence tied to when the head became active.
## Issue Context
Persist or derive a trustworthy current-head activation boundary and require explicit current-SHA/cycle evidence where supported. Do not let editing an old comment move it into the current cycle.
## Fix Focus Areas
- .github/workflows/peer-review-orchestrator.yml[119-124]
- .github/workflows/peer-review-orchestrator.yml[197-209]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+157
to
+160
| function controlEntries(comments) { | ||
| const controls = []; | ||
| for (const comment of comments) { | ||
| const provider = providerFor(comment.user?.login); |
There was a problem hiding this comment.
3. Historical controls acknowledge new cycles 🐞 Bug ≡ Correctness
controlEntries scans every provider comment without a timestamp, SHA, or cycle restriction, and any previously selected checkbox makes that provider acknowledged for the current cycle. A control selected for an earlier head can consequently authorize completion evidence for the new head.
Agent Prompt
## Issue description
Interactive controls from historical provider comments are reused in every new head cycle, including their selected state.
## Issue Context
Only controls demonstrably associated with the active head/cycle should affect acknowledgment. Published controls should also include the binding information used for validation.
## Fix Focus Areas
- .github/workflows/peer-review-orchestrator.yml[157-174]
- .github/workflows/peer-review-orchestrator.yml[225-239]
- .github/workflows/peer-review-orchestrator.yml[255-267]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+64
to
+68
| function providerFor(login) { | ||
| const value = (login || '').toLowerCase(); | ||
| if (value.includes('coderabbit')) return 'coderabbit'; | ||
| if (value.includes('qodo')) return 'qodo'; | ||
| if (value.includes('devin')) return 'devin'; |
There was a problem hiding this comment.
4. Provider usernames are spoofable 🐞 Bug ⛨ Security
providerFor authenticates providers through a substring in the login, so an ordinary account named like coderabbit-helper or qodo-reviewer is accepted as that provider. Such accounts can submit completion comments or recognized controls and satisfy required-provider state during a PR-triggered collection run.
Agent Prompt
## Issue description
Provider identity is inferred from an arbitrary substring of an unauthenticated username, allowing lookalike accounts to produce trusted evidence.
## Issue Context
Use an explicit allowlist of exact provider bot/app identities and, where available, validate bot/app metadata rather than display-login text.
## Fix Focus Areas
- .github/workflows/peer-review-orchestrator.yml[64-72]
- .github/workflows/peer-review-orchestrator.yml[157-171]
- .github/workflows/peer-review-orchestrator.yml[197-215]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+177
to
+182
| function acknowledgedControls(comments, controls) { | ||
| const authorizedAssociations = new Set(['OWNER', 'MEMBER', 'COLLABORATOR']); | ||
| return comments.filter(comment => { | ||
| if (!comment.body?.includes(operatorAckMarker)) return false; | ||
| if (!authorizedAssociations.has(comment.author_association)) return false; | ||
| return comment.body.includes(`cycle_id: ${cycleId}`); |
There was a problem hiding this comment.
5. Acknowledgements lack executor authorization 🐞 Bug ⛨ Security
acknowledgedControls accepts every OWNER, MEMBER, or COLLABORATOR rather than a separately authorized executor, and it does not validate the required action against an allowlist. Any repository collaborator can therefore acknowledge a control and unlock already-observed provider evidence despite not being authorized to perform the UI action.
Agent Prompt
## Issue description
The acknowledgement parser equates broad repository association with authorization to execute provider UI actions and ignores the declared action value.
## Issue Context
Validate the exact actor against a configured executor allowlist and parse exact structured fields, including an allowlisted provider/action/control tuple. Reject ambiguous, duplicate, missing, or unauthorized fields.
## Fix Focus Areas
- .github/workflows/peer-review-orchestrator.yml[177-190]
- docs/ops/OPERATOR_INTERACTIVE_ACTIONS.md[17-33]
- docs/ops/OPERATOR_INTERACTIVE_ACTIONS.md[44-48]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
timerloggedout-spec
added a commit
that referenced
this pull request
Aug 18, 2026
Focused follow-up to #241. Distinguishes provider UI controls from substantive review feedback so CodeRabbit/Qodo control notices do not summon Jules. Extends recognition to edited provider comments, tightens trusted bot logins, and advances peer-orchestrator to event-driven verified second-pass dispatch. Validation: YAML + Node syntax checks, classifier tests, git diff --check against master. Hygiene gates green; Vercel rate-limit and GitLab mirror status are external non-blockers.
timerloggedout-spec
added a commit
that referenced
this pull request
Sep 14, 2026
…estrator.yml bug origin (PR #241 / Manus agent); confirm pr-production-ledger.yml unrelated
timerloggedout-spec
added a commit
that referenced
this pull request
Sep 15, 2026
…comment-loop incident * docs(process): add retroactive automation-review lesson from PR #390 comment-loop incident Adds a new section to the evidence-led-monorepo-ops skill documenting the root cause of the PR #390 / issue #507 comment-loop incident and proposing a lightweight periodic retroactive review cadence for automation misbehavior patterns (comment loops, redundant CI, spurious re-triggers), so these are proactively sampled for instead of only reacted to via auto-filed overflow issues. No workflow files under .github/workflows/** were modified; this is a docs-only change. Diagnosis was read-only (no edits to PR #390 or issue #507). * docs(process): add verified attribution addendum for peer-review-orchestrator.yml bug origin (PR #241 / Manus agent); confirm pr-production-ledger.yml unrelated
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This replaces the previous “any peer activity or timeout” handoff with a SHA-bound peer-response contract. Provider-owned checkboxes and buttons are now recorded as pending operator actions rather than copied into relay comments or treated as reviewer completion.
The peer gate now observes CodeRabbit, Qodo, and Devin responses, records the current provider state in one idempotently updated comment, and only releases the routed second-pass workflow when every configured required provider has completion evidence for the live PR head SHA.
gemini-after-peersadditionally rejects a stale head SHA and any state other thanresponses_collected/ready: true.The new
docs/ops/OPERATOR_INTERACTIVE_ACTIONS.mdrunbook defines the restricted acknowledgement protocol for a separately authorized Operator Action Executor. It explicitly prohibits copying browser cookies or treatingrefTemplates, Actions caches, or a broad Actions token as UI-control authority.Behavioral changes
Trigger reviewcheckbox becomespending_operator_actionuntil a permitted operator/agent acknowledges the exact source control.action_acknowledged, but does not release second pass.provider_completed.Validation
actions/github-scriptblock with Node.js.git diff --check.Security boundary
No browser cookies, session exports, or provider credentials are read, moved, logged, cached, or added to the repository. This change records the request and waits for external operator/provider evidence; it does not select a provider UI control itself.