🎨 Palette: Improve termux-multi-agent telemetry dashboard UX - #17
Conversation
- Redesigned `termux-multi-agent/dashboard.py` using `rich` (`Live`, `Table`, `Panel`, `Group`) for a modern, flicker-free terminal UI. - Implemented high-level structural rendering with clean colors mapped to statuses. - Handled empty states gracefully with step-by-step pipeline guidance. - Improved terminal clean-up on exit and added a friendly parting message. - Saved critical UX learning in `.Jules/palette.md`. Co-authored-by: timerloggedout-spec <233432881+timerloggedout-spec@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-project-automation
Bot
moved this to Todo
in @timerloggedout-spec's untitled project team planning
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
|
Warning Review limit reached
Next review available in: 44 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe dashboard replaces ANSI screen clearing with Rich rendering. It sorts telemetry by timestamp, builds styled panels and tables, refreshes through ChangesRich dashboard rendering
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant main
participant Live
participant make_dashboard
participant Console
main->>make_dashboard: build dashboard renderable
main->>Live: refresh display every second
Live->>Console: render Rich dashboard
main->>Console: show styled exit panel on interruption
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| console.clear() | ||
| console.print(Panel( |
There was a problem hiding this comment.
🟡 Exiting the dashboard wipes whatever was on the terminal before it started
On exit the whole terminal display is erased (console.clear() at termux-multi-agent/dashboard.py:155) right after the previous screen contents were restored, so the user's earlier terminal output disappears.
Impact: Users lose the commands and output that were visible before launching the dashboard, contradicting the intended clean restore.
Alternate-screen restore followed by an explicit clear
Live(..., screen=True) at termux-multi-agent/dashboard.py:149 renders into the terminal's alternate screen buffer. When KeyboardInterrupt propagates out of the with block, Live's __exit__ leaves the alternate screen and the user's original screen contents are restored. The handler then calls console.clear(), which emits a clear-screen/home sequence against that restored primary screen, destroying the content that was just brought back before printing the goodbye panel. Simply printing the panel (without clearing) achieves the intended "clean restore + warm parting message".
| console.clear() | |
| console.print(Panel( | |
| # Live(screen=True) already restored the previous terminal contents | |
| console.print() |
Was this helpful? React with 👍 or 👎 to provide feedback.
| target, | ||
| agent, | ||
| attempt, | ||
| status_str, | ||
| message, | ||
| timestamp | ||
| ) | ||
|
|
There was a problem hiding this comment.
📝 Info: Table cell strings are parsed as Rich markup
message, agent, and target are passed to table.add_row as plain strings, which Rich renders with console markup enabled. Telemetry messages currently emitted by termux-multi-agent/src/telemetry.py and provision_agent.py:318-369 are static literals with no square brackets, so this is safe today. However, any future message containing bracketed text (e.g. an exception string or [INFO] prefix) would be silently swallowed as a style tag or, if malformed, raise MarkupError inside the Live loop and terminate the dashboard. Wrapping these values in Text(...) would make cell rendering literal.
Was this helpful? React with 👍 or 👎 to provide feedback.
| return sorted(active_jobs.values(), key=lambda x: x.get("timestamp", "")) | ||
|
|
There was a problem hiding this comment.
📝 Info: Sorting by timestamp assumes the field is always a string
sorted(..., key=lambda x: x.get("timestamp", "")) returns None when a log line contains an explicit "timestamp": null, and comparing None with str raises TypeError, which the surrounding try/except no longer covers (the sort happens after it). The current writer always sets a strftime string, so this is not reachable today, but key=lambda x: str(x.get("timestamp") or "") would make it robust against hand-edited or third-party log lines.
Was this helpful? React with 👍 or 👎 to provide feedback.
| empty_text = Text() | ||
| empty_text.append("\n[ Waiting for background agent pipelines to initialize... ]\n\n", style="italic cyan") | ||
| empty_text.append("To start the multi-agent orchestration pipeline, run:\n", style="dim") | ||
| empty_text.append(" ./run_agent.sh\n", style="bold green") | ||
| empty_text.append("\nThis dashboard will automatically update once events are received.\n", style="dim") | ||
| empty_text.append("Press Ctrl+C to exit.", style="dim red") | ||
|
|
There was a problem hiding this comment.
🔍 Log path is relative to the process CWD, and empty-state guidance may mislead
TELEMETRY_LOG remains a bare relative filename while the actual stream file lives at the repo root, not in termux-multi-agent/. The new empty-state panel tells the user to run ./run_agent.sh, but if the dashboard is launched from a different directory than the agent, the panel will keep showing 'waiting' forever even though events are being written. Resolving the path relative to the script location (or surfacing the absolute path in the header) would avoid the confusing dead-end.
Was this helpful? React with 👍 or 👎 to provide feedback.
| from rich.console import Console, Group | ||
| from rich.table import Table | ||
| from rich.panel import Panel | ||
| from rich.live import Live | ||
| from rich.text import Text | ||
| from rich.box import ROUNDED | ||
| except ImportError: | ||
| # Clean fallback warning | ||
| print("[ERROR] 'rich' library is required. Please run: pip install rich") | ||
| sys.exit(1) | ||
|
|
There was a problem hiding this comment.
🔍 New runtime dependency on rich is not declared
The dashboard now hard-fails with sys.exit(1) if rich is missing, but no requirements file in the repo (e.g. requirements-base.txt) was updated to declare it. On a fresh Termux install the dashboard becomes unusable until the user reads the error and installs manually.
Was this helpful? React with 👍 or 👎 to provide feedback.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@termux-multi-agent/dashboard.py`:
- Around line 32-39: Update the telemetry parsing loop around json.loads and the
target assignment to accept only dictionary records with a string target (or no
target, using “System”); skip invalid shapes and continue processing subsequent
lines instead of allowing them to abort the read. Add a regression test covering
an invalid record followed by a valid record and verify the valid record is
retained.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 7985111a-0e82-4eca-9c16-125d6170abca
📒 Files selected for processing (2)
.Jules/palette.mdtermux-multi-agent/dashboard.py
| try: | ||
| entry = json.loads(line) | ||
| target = entry.get("target") or "System" | ||
| active_jobs[target] = entry | ||
| except json.JSONDecodeError: | ||
| continue | ||
| except Exception: | ||
| pass |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Skip telemetry records with an invalid JSON shape.
Line 34 assumes that every valid JSON value is an object. A JSON array, scalar, or object with a non-string target can raise during parsing. Lines 38-39 then stop the whole read, so later valid telemetry records do not appear.
Validate the record type and target before using them. Add a regression test with an invalid record followed by a valid record.
Proposed fix
try:
entry = json.loads(line)
- target = entry.get("target") or "System"
+ if not isinstance(entry, dict):
+ continue
+ target = entry.get("target")
+ if not isinstance(target, str) or not target:
+ target = "System"
active_jobs[target] = entry
except json.JSONDecodeError:
continue📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| try: | |
| entry = json.loads(line) | |
| target = entry.get("target") or "System" | |
| active_jobs[target] = entry | |
| except json.JSONDecodeError: | |
| continue | |
| except Exception: | |
| pass | |
| try: | |
| entry = json.loads(line) | |
| if not isinstance(entry, dict): | |
| continue | |
| target = entry.get("target") | |
| if not isinstance(target, str) or not target: | |
| target = "System" | |
| active_jobs[target] = entry | |
| except json.JSONDecodeError: | |
| continue | |
| except Exception: | |
| pass |
🧰 Tools
🪛 Ruff (0.16.0)
[error] 38-39: try-except-pass detected, consider logging the exception
(S110)
[warning] 38-38: Do not catch blind exception: Exception
(BLE001)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@termux-multi-agent/dashboard.py` around lines 32 - 39, Update the telemetry
parsing loop around json.loads and the target assignment to accept only
dictionary records with a string target (or no target, using “System”); skip
invalid shapes and continue processing subsequent lines instead of allowing them
to abort the read. Add a regression test covering an invalid record followed by
a valid record and verify the valid record is retained.
- termux-multi-agent/dashboard.py: Replaced screen-clearing raw ANSI escapes with differential, flicker-free rendering via `rich.live.Live` & `rich.table.Table`. Implemented colorized level mappings and an onboarding empty state with step-by-step instructions. - deepcli-tui/tui.py: Consolidated redundant Help and Commands panels into a single, beautifully organized TUI Commands Guide to eliminate double pauses/keyboard inputs. - archwiz/archwiz.py: Refactored exit sequence to print a random, stylized goodbye signature for all exit types (normal choice '0', Ctrl+C, Ctrl+D). Resolved container/headless OSError crashes by fallback from `os.getlogin()` to `getpass.getuser()`. - Saved critical UX learnings in `.Jules/palette.md`. Co-authored-by: timerloggedout-spec <233432881+timerloggedout-spec@users.noreply.github.com>
| # Uniform, delightful exit signature for all exits (choice '0', Ctrl+C, Ctrl+D) | ||
| print(G + random.choice([ | ||
| "ArchWiz signing off. Forge well.", | ||
| "Until next cycle. Stay l33T.", | ||
| "Dashboard closed. The Forge awaits.", | ||
| "ArchWiz out. Happy hacking.", | ||
| "Systems stable. ArchWiz offline." | ||
| ]) + N) |
There was a problem hiding this comment.
📝 Info: "Uniform exit signature" is bypassed by an early return inside the menu loop
The new unconditional farewell after the loop covers break paths, but the staged-block restore branch does return from main() mid-loop (archwiz/archwiz.py:211), so that exit path prints no farewell. Also, if main() is imported/called elsewhere, the message now prints on every loop exit rather than only on explicit quit.
Was this helpful? React with 👍 or 👎 to provide feedback.
github-project-automation
Bot
moved this from Todo
to Done
in @timerloggedout-spec's untitled project team planning
This branch was successfully deployed
1 participant
I have redesigned the
termux-multi-agentreal-time telemetry dashboard (dashboard.py) to deliver a modern, accessible, and delightful terminal experience.💡 What:
termux-multi-agent/dashboard.pyfrom raw ANSI screen clears to standard differential terminal rendering viarich.live.Liveandrich.table.Table.KeyboardInterruptwith a clean screen restore and a warm parting panel..Jules/palette.md.🎯 Why:
♿ Accessibility & Quality:
ImportErrorsafely to avoid crashing in environments without dependencies.PR created automatically by Jules for task 10623504202529550216 started by @timerloggedout-spec
Summary by CodeRabbit
New Features
Bug Fixes