Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add execution timeout for remote UDFs #827

Merged
merged 6 commits into from
Sep 10, 2024
Merged

feature: add execution timeout for remote UDFs #827

merged 6 commits into from
Sep 10, 2024

Conversation

amamiya-len
Copy link
Contributor

PR checklist:

  • Did you run ClangFormat ? Yes
  • Did you separate headers to a different section in existing community code base ? Yes
  • Did you surround proton: starts/ends for new code in existing community code base ? Yes

Please write user-readable short description of the changes:
enable execution timeout setting to close #5898

@amamiya-len amamiya-len force-pushed the feature/issue-5898-add-execution-timeout-setting branch from ac247bf to 4ffb74a Compare August 23, 2024 08:25
@amamiya-len amamiya-len force-pushed the feature/issue-5898-add-execution-timeout-setting branch 2 times, most recently from b0a14c4 to 6bf17ab Compare August 26, 2024 02:08
@amamiya-len amamiya-len force-pushed the feature/issue-5898-add-execution-timeout-setting branch from 0764922 to 10e3a86 Compare August 28, 2024 05:49
@amamiya-len
Copy link
Contributor Author

amamiya-len commented Aug 29, 2024 •
edited
Loading

TODO:

  • change the way to store the props in ASTRemoteFunction.
  • add more unit tests

@amamiya-len amamiya-len force-pushed the feature/issue-5898-add-execution-timeout-setting branch 2 times, most recently from 8e1b6fc to f92b247 Compare September 2, 2024 02:50
sunset3000
sunset3000 reviewed Sep 9, 2024
View reviewed changes
src/Functions/UserDefined/RemoteUserDefinedFunction.h Outdated Show resolved Hide resolved
src/Parsers/ASTCreateFunctionQuery.cpp Outdated Show resolved Hide resolved
src/Parsers/ParserCreateFunctionQuery.cpp Outdated Show resolved Hide resolved
src/Parsers/tests/gtest_create_remote_func_parser.cpp Show resolved Hide resolved
src/Coordination/MetaStoreConnection.cpp Outdated Show resolved Hide resolved
src/Functions/UserDefined/UserDefinedFunctionConfiguration.h Show resolved Hide resolved
src/Parsers/tests/gtest_create_remote_func_parser.cpp Show resolved Hide resolved
src/Parsers/ASTCreateFunctionQuery.cpp Outdated Show resolved Hide resolved
src/Parsers/ParserCreateFunctionQuery.cpp Show resolved Hide resolved
src/Parsers/ParserKeyValuePairsSet.h Outdated Show resolved Hide resolved
@amamiya-len amamiya-len force-pushed the feature/issue-5898-add-execution-timeout-setting branch from 2e16ad0 to 7bd073f Compare September 9, 2024 10:54
@amamiya-len amamiya-len force-pushed the feature/issue-5898-add-execution-timeout-setting branch from 7bd073f to 10e6f9b Compare September 10, 2024 07:10
@sunset3000 sunset3000 merged commit 7ac8e72 into develop Sep 10, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunset3000 sunset3000 sunset3000 approved these changes

Assignees
No one assigned
Labels
pr-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amamiya-len @sunset3000