Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix session range comparision expression #812

Merged
merged 4 commits into from
Aug 7, 2024
Merged

fix session range comparision expression #812

merged 4 commits into from
Aug 7, 2024

Conversation

yl-lisen
Copy link
Collaborator

@yl-lisen yl-lisen commented Aug 7, 2024

Fix #810

@yl-lisen yl-lisen requested a review from yokofly August 7, 2024 07:33
@yl-lisen yl-lisen self-assigned this Aug 7, 2024
yokofly
yokofly reviewed Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@yokofly yokofly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are missing tests about incorrect input with window function, thus I expected at least keep the old if condition check still instead assert.

src/TableFunctions/TableFunctionSession.cpp Show resolved Hide resolved
src/Parsers/Streaming/ASTSessionRangeComparision.cpp Show resolved Hide resolved
@yokofly
Copy link
Collaborator

yokofly commented Aug 7, 2024

waiting CI

@yl-lisen
Copy link
Collaborator Author

yl-lisen commented Aug 7, 2024

flakey stateless test case 00301_csv failed.

@yl-lisen yl-lisen merged commit 51917e9 into develop Aug 7, 2024
21 checks passed
@yl-lisen yl-lisen deleted the bugfix/issue-810-fix-session-range-comparation-expression branch August 7, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yokofly yokofly yokofly approved these changes

Assignees

@yl-lisen yl-lisen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unbalanced parentheses in a session are considered an error
2 participants
@yl-lisen @yokofly