-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: format schema cache is not cleared after the schema is dropped #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-min
requested review from
chenziliang,
yl-lisen,
qijun-niu-timeplus and
yokofly
June 26, 2024 16:37
chenziliang
reviewed
Jun 27, 2024
LGTM in general |
zliang-min
force-pushed
the
bugfix/schema-cache-invalidation
branch
from
July 4, 2024 22:56
b340636
to
8d9829e
Compare
chenziliang
reviewed
Jul 5, 2024
chenziliang
reviewed
Jul 5, 2024
chenziliang
approved these changes
Jul 5, 2024
(Jove Github Bot) added it to the current sprint. |
(Jove Github Bot) moved this ticket out of the GitHub project(up to 1200 tickets for one project). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist:
proton: starts/ends
for new code in existing community code base ?Please write user-readable short description of the changes:
In this PR, I have ported a few changes related to
ProtobufSchemas
from CH repo for cleaning up the Protobuf schema cache (please check theCommits
tag for what are ported). And based on those changes, I added the logic toDROP FORMAT SCHEMA
andCREATE OR REPLACE FORMAT SCHEMA
to clear theProtobuf schema cache.Here is a use case that is blocked by this bug:
c
.c
will always be empty, because the schema is cached, and even after we re-create it, it still uses the old cached schema.