Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support to use SQL to CRUD JavaScript UDF/UDA. close #3072. #109

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Support to use SQL to CRUD JavaScript UDF/UDA. close #3072. #109

merged 7 commits into from
Oct 12, 2023

Conversation

sunset3000
Copy link
Collaborator

PR checklist:

  • Did you run ClangFormat ? Yes
  • Did you separate headers to a different section in existing community code base ? Yes
  • Did you surround proton: starts/ends for new code in existing community code base ? Yes

Please write user-readable short description of the changes:
Support to use SQL to CRUD JavaScript UDF/UDA. close #3072.

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sunset3000 sunset3000 force-pushed the feature/issue-3072-SQL-JS-UDF branch from f240a0e to e03595c Compare September 19, 2023 08:14
qijun-niu-timeplus
qijun-niu-timeplus reviewed Sep 21, 2023
View reviewed changes
src/Parsers/Lexer.h Outdated Show resolved Hide resolved
src/Parsers/ParserCreateFunctionQuery.cpp Show resolved Hide resolved
src/Parsers/Streaming/ParserArguments.cpp Show resolved Hide resolved
src/Parsers/Streaming/ParserJavaScriptFunction.h Outdated Show resolved Hide resolved
src/Parsers/Streaming/ParserArguments.cpp Show resolved Hide resolved
src/Parsers/Streaming/ASTJavaScriptFunction.h Outdated Show resolved Hide resolved
src/Parsers/Streaming/ParserJavaScriptFunction.cpp Outdated Show resolved Hide resolved
src/Functions/UserDefined/UDFHelper.cpp Show resolved Hide resolved
src/Functions/UserDefined/UDFHelper.cpp Show resolved Hide resolved
src/Parsers/ASTCreateFunctionQuery.cpp Show resolved Hide resolved
@sunset3000 sunset3000 force-pushed the feature/issue-3072-SQL-JS-UDF branch 4 times, most recently from fa161cb to 127eed0 Compare September 26, 2023 08:21
@sunset3000 sunset3000 force-pushed the feature/issue-3072-SQL-JS-UDF branch 2 times, most recently from fe29037 to f28d67a Compare October 11, 2023 08:55
@sunset3000 sunset3000 force-pushed the feature/issue-3072-SQL-JS-UDF branch from f28d67a to 2ebd121 Compare October 12, 2023 02:00
@yokofly
Copy link
Collaborator

yokofly commented Oct 12, 2023

@qijun-niu-timeplus can the above 2 comments be resolved?
#109 (comment)
#109 (comment)

@yokofly yokofly merged commit 924b98d into develop Oct 12, 2023
17 checks passed
@yokofly yokofly deleted the feature/issue-3072-SQL-JS-UDF branch February 5, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenziliang chenziliang chenziliang left review comments

@qijun-niu-timeplus qijun-niu-timeplus qijun-niu-timeplus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sunset3000 @CLAassistant @yokofly @chenziliang @qijun-niu-timeplus