Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pat: correct numeric matching #329

Closed
wants to merge 2 commits into from
Closed

pat: correct numeric matching #329

wants to merge 2 commits into from

Conversation

timbray
Copy link
Owner

@timbray timbray commented Jul 3, 2024

addresses #27

This is now consistent with current Ruler behavior except for the bug reported in aws/event-ruler#163, which does not occur in Quamina.

addresses #27

Signed-off-by: Tim Bray <[email protected]>
@timbray
Copy link
Owner Author

timbray commented Jul 3, 2024

Drat. Pulled in math/rand/v2, not realizing it's a go v1.22+ thing. I wish golangci-lint would catch this on my desktop. I guess the correct thing to do is roll back to math/rand which will cause CI complaints but those can be ignored. Fortunately Quamina doesn't need secure random numbers, they're just for test data.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 93.93939% with 6 lines in your changes missing coverage. Please review.

Project coverage is 96.23%. Comparing base (b1c32f5) to head (49e80c7).

Files Patch % Lines
value_matcher.go 84.61% 5 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
- Coverage   96.48%   96.23%   -0.26%     
==========================================
  Files          18       18              
  Lines        1764     1804      +40     
==========================================
+ Hits         1702     1736      +34     
- Misses         35       40       +5     
- Partials       27       28       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timbray
Copy link
Owner Author

timbray commented Jul 3, 2024

Hm, those benchmarks took me by surprise. Will need to study some more. Converting to draft PR.

@timbray timbray marked this pull request as draft July 3, 2024 16:08
@timbray timbray closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants