Issue 252 #259
Merged
Issue 252 #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignore fields with no values Signed-off-by: Tim Bray <[email protected]>
Signed-off-by: Tim Bray <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
=======================================
Coverage 96.19% 96.19%
=======================================
Files 17 17
Lines 2126 2129 +3
=======================================
+ Hits 2045 2048 +3
Misses 54 54
Partials 27 27 ☔ View full report in Codecov by Sentry. |
embano1
approved these changes
Dec 9, 2023
| checkXEqual(t, wanted[want], matches) | ||
| } | ||
| } | ||
| func checkXEqual(t *testing.T, x1s []X, x2s []X) { |
There was a problem hiding this comment.
nit: I just wonder whether slices.Sort and then slices.Equal from https://pkg.go.dev/golang.org/x/exp/slices would be more clear instead of creating a new equality check helper?
There was a problem hiding this comment.
Good idea. Unfortunately the "X" type doesn't implement cmp.ordered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that
{"data": {"field": []}}, which is syntactically valid, would makeaddPatternblow up. Which at one level is sane because it can't match anything, but on the other hand if you're generating Patterns it would be easy to write code to "match any of the elements of my arrayPartNumbers" and ifPartNumberswas empty you'd get this kind of pattern and while it couldn't match anything, that would be the expected correct behavior.The reason for excluding that particular message in the gosec linter is that the linter wants the crypto/rand as opposed to math/rand, but we want to retain the use of a fixed seed for the random number generator for testing/debugging purposes, and crypto/rand doesn't seem to support that and also is slower.