Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov action not running? #309

Closed
embano1 opened this issue May 26, 2024 · 11 comments
Closed

Codecov action not running? #309

embano1 opened this issue May 26, 2024 · 11 comments
Assignees
Labels
github_actions Pull requests that update GitHub Actions code

Comments

@embano1
Copy link
Collaborator

embano1 commented May 26, 2024

Just noticed this note in the unit tests in PR #308:

Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/125fc84a9a348dbcf27191600683ec096ec9021c/dist/codecov' failed with exit code 1

@embano1 embano1 added the github_actions Pull requests that update GitHub Actions code label May 26, 2024
@embano1 embano1 self-assigned this May 26, 2024
@embano1
Copy link
Collaborator Author

embano1 commented May 26, 2024

Seems something changed in Codecov requiring token:

Error: Codecov token not found. Please provide Codecov token with -t flag.

Will investigate

@timbray
Copy link
Owner

timbray commented May 26, 2024

Oh, will investigate too. I had the same problem on topfew and figured it out. But wait, the actions report said everything passed?!?!

@timbray
Copy link
Owner

timbray commented May 26, 2024

OK, you have to go in the settings for "Secrets and Variables" and set up a "repository secret", which I did. Is there a way to force the actions to re-run without pushing something?

@embano1
Copy link
Collaborator Author

embano1 commented May 27, 2024

Hm, seems that didn't fix it? Just reran your PR checks and still throws: https://github.com/timbray/quamina/actions/runs/9237494760/job/25465928548#step:8:32

Did you follow this procedure? https://docs.codecov.com/docs/adding-the-codecov-token

@timbray
Copy link
Owner

timbray commented May 27, 2024 via email

@embano1
Copy link
Collaborator Author

embano1 commented May 27, 2024

See Re-run all Jobs button

image

@embano1
Copy link
Collaborator Author

embano1 commented May 27, 2024

Oh, will investigate too. I had the same problem on topfew and figured it out. But wait, the actions report said everything passed?!?!

Guess the action is configured to not fail the workflow on error

@timbray
Copy link
Owner

timbray commented May 27, 2024

Well, per the instructions at https://docs.codecov.com/docs/adding-the-codecov-token I added

env:
    CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

And that certainly changed things. It found the token, lots of failures saying token validation failed. I went and regenerated the token over at Codecov, updated the repository secret at GitHub. Not sure what to do next, will take a break and research some more.

@timbray
Copy link
Owner

timbray commented May 27, 2024

Hmm, I notice that they're talking about codecov-action@4 in the docs page, our codecov point release is still 3.something. Worth bumping to @4?

@embano1
Copy link
Collaborator Author

embano1 commented May 28, 2024

Yeah, let's try that!

update: we're already on latest release: codecov/codecov-action@125fc84

@embano1
Copy link
Collaborator Author

embano1 commented May 28, 2024

Ah, looks like it's working now and in your PR. Closing issue.

@embano1 embano1 closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

No branches or pull requests

2 participants