Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce copy-pasted setup #89

Merged
merged 2 commits into from
Sep 8, 2017
Merged

Conversation

Guria
Copy link
Collaborator

@Guria Guria commented Sep 5, 2017

Less original code copied => less sensible to react-scripts changes and less backporting changes.

no breaking changes here.
tested on https://github.com/Guria/rewired-bem-boilerplate

@Guria
Copy link
Collaborator Author

Guria commented Sep 6, 2017

Ok, removed duplication of createJestConfig as well. Still should be no breaking.

@timarney
Copy link
Owner

timarney commented Sep 6, 2017

Thinking I'll merge this in later this week and publish it as "next" version for people to test with.

@timarney timarney merged commit 4722e19 into timarney:master Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants