add mysql2 package #178
Merged
add mysql2 package #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-smart
requested changes
Mar 27, 2024
packages/mysql2/package.json
Outdated
| @@ -0,0 +1,39 @@ | |||
| { | |||
| "name": "@sqlfx/mysql2", | |||
| "version": "0.45.0", | |||
There was a problem hiding this comment.
If you can set the version to 0.0.0, then run pnpm changeset and add a minor changeset for the initial version.
There was a problem hiding this comment.
I see that the changeset version is literally "minor". Did you mean 0.0.1 instead? Sorry, I've never used changesets before.
|
Thanks Tim. Assuming that you don't want to change any of the package naming or somehow extract common logic, I think this is good to go. I am sure that there exist administrative/introspection queries where the current response type/mapping don't hold, but I think that's the same for the existing mariadb adapter. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an additional mysql package based upon the node-mysql2 package, copying directly from the existing mariadb-based package. We have experienced issues with the mariadb pool implementation and would prefer to use node-mysql2. If the naming is awkward, we might consider adding suffixes to the implementation packages, ie mysql-mariadb and mysql-mysql2, or simply replacing the mariadb implementation.
The node-mysql2 promise-based connection API does not expose query streams, so we are forced to access the private, underlying connection instance.
I have successfully run the examples against a local mysql instance.