Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates of the repository #114

Closed
wants to merge 10 commits into from
Closed

Updates of the repository #114

wants to merge 10 commits into from

Conversation

benoit9126
Copy link
Contributor

@benoit9126 benoit9126 commented Aug 22, 2022

Hi,

Here is a large proposal to update this Python package. It contains

  1. The drop of Python 2 support Drop Python 2 support #115
  2. ~A more recent generation of the protobuf Python code to solve latest protobuf 4.21 break mapbox-vertor-tile #113 ~ Regenerate protobuf python file #119
  3. The usage of GitHub actions Usage of GHA instead of Travis #116
  4. The usage of Poetry with a pyproject.toml
  5. The usage of pre-commit (black, isort, flake8, etc) Pre-commit tools #121
  6. The usage of tox for the tests. Usage of GHA instead of Travis #116

@vincentsarago
Copy link

@benoit9126 I'm not the repo owner or maintainer but IMO you should split this PR in multiple small PR and first discuss change in issue (e.g usage of poetry), it might ease the reviewer and increase the likelihood of the fix to be merged :-)

@benoit9126
Copy link
Contributor Author

Ok. Do you have a priority order among the points listed above?

This was referenced Aug 25, 2022
@rmarianski
Copy link
Member

Ok. Do you have a priority order among the points listed above?

my 2c is dropping python2 support and protobuf generation are higher priority.

@benoit9126 benoit9126 marked this pull request as draft December 20, 2022 09:17
@benoit9126
Copy link
Contributor Author

@rmarianski : The next possible steps would be:

  1. A more recent generation of the protobuf Python code to solve latest protobuf 4.21 break mapbox-vertor-tile #113
  2. The usage of Poetry with a pyproject.toml
  3. The usage of pre-commit (black, isort, flake8, etc)

I start to implement the first which is the most important for me. If the community aggrees with the two other proposals, I can provide them too.

@benoit9126
Copy link
Contributor Author

  1. I also note that there are some troubles between the round function of Python 2 and 3 that forces you to use quantize and to pass a round function in some operators (encode for instance). As now, only Python 3 is supported, we could remove this argument round_fn and just use the round function.

@benoit9126
Copy link
Contributor Author

@rmarianski I close this PR as everything was added in other PR.

@benoit9126 benoit9126 closed this Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants