-
Notifications
You must be signed in to change notification settings - Fork 327
[Build] Migrate to scikit-build-core #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 109 commits
711367c
e4a024a
e86bf86
1ef1e3f
767b1b3
c7a5b6b
e21ddd9
d1cc5d6
4c0ebe4
b14db98
76e9df7
df9ae25
dda4a45
cfc10f7
93f067a
6186c04
444700c
2d0592f
7835895
4714c7b
631e863
3e4d8fe
03e2424
be422e7
e813cec
ce883ac
f3101c2
5976a6a
8423e48
cb9ff78
5c4240b
b2b7ea3
a9152be
558b446
b7e4107
d1de829
2621eab
216887a
68fc2b2
c84008c
7a7144e
03001e0
1227ce6
ae13f57
3c91e4e
605a2a7
716f2a0
f9d387d
a7e959a
a392f97
9cf48ef
d074a3c
8de0e2e
a2071be
a32691f
dd0a42d
395fd24
ae6be4b
d435b25
bfe1e42
2af11f6
5270459
7561b89
9db45df
0858946
10a87fb
56cd28b
59a6a10
b03260e
bf246a3
e13e8a7
b2c3133
659225a
988e666
afe819f
1bd2cab
8940863
5cb5322
6ab87b0
3a8d5d0
fbf01f4
0d4a74b
47d7537
0e06b95
c8d641b
0724595
b1e653e
e55f34c
85d0df0
5592fd0
665ba44
e5230cb
1078714
74dabc4
695f128
a7eaee1
c174093
01c7c5a
707d433
54b40fa
901de58
65f3841
5d3415f
1c98b7e
96030a8
f184877
3eb1b34
110e27a
cf0edde
44e9644
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| name: Dist | ||
| on: | ||
| schedule: | ||
| # gemini said this is 6:00 china time | ||
| - cron: '0 22 * * *' | ||
| release: | ||
| types: [ published ] | ||
| pull_request: | ||
|
|
||
| env: | ||
| PYTHON_VERSION: '3.12' | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| build-wheels: | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-22.04, ubuntu-22.04-arm, macos-16] | ||
oraluben marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| include: | ||
| - os: ubuntu-22.04 | ||
| cuda_version: "12.1" | ||
| - os: ubuntu-22.04-arm | ||
| cuda_version: "12.8" | ||
| fail-fast: true | ||
| runs-on: ${{ matrix.os }} | ||
| env: | ||
| CUDA_VERSION: ${{ matrix.cuda_version }} | ||
| NO_VERSION_LABEL: ${{ github.event_name != 'release' }} | ||
oraluben marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 1 | ||
| submodules: recursive | ||
|
|
||
| - name: ccache | ||
| uses: hendrikmuhs/[email protected] | ||
| if: startsWith(matrix.os, 'macos') | ||
| with: | ||
| create-symlink: true | ||
| key: ${{ github.job }}-${{ matrix.os }} | ||
|
|
||
| - name: Build wheels | ||
| uses: pypa/[email protected] | ||
| with: | ||
| output-dir: wheelhouse | ||
| config-file: "{package}/pyproject.toml" | ||
|
|
||
| # just for now to list all files | ||
| - name: List wheels | ||
| id: ls-whl | ||
| run: echo "whl_name=$(ls wheelhouse | head -n1)" >> $GITHUB_OUTPUT | ||
|
|
||
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ${{ steps.ls-whl.outputs.whl_name }}.zip | ||
| path: wheelhouse/${{ steps.ls-whl.outputs.whl_name }} | ||
| compression-level: 0 | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -51,9 +51,9 @@ jobs: | |||||||||||||||||||||||||
| - name: Run format check | ||||||||||||||||||||||||||
| run: | | ||||||||||||||||||||||||||
| source "${{ runner.tool_cache }}/${{ env.VENV_DIR }}/bin/activate" | ||||||||||||||||||||||||||
| git submodule update --init --recursive | ||||||||||||||||||||||||||
| git submodule update --init --recursive --checkout | ||||||||||||||||||||||||||
| mkdir -p build | ||||||||||||||||||||||||||
| cd build; cmake .. -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DUSE_ROCM=ON; cd .. | ||||||||||||||||||||||||||
| cd build; USE_ROCM=1 cmake .. -DCMAKE_EXPORT_COMPILE_COMMANDS=ON; cd .. | ||||||||||||||||||||||||||
| if ! output=$(./format.sh 2>&1); then | ||||||||||||||||||||||||||
| echo "------------------------------------" | ||||||||||||||||||||||||||
| echo "message:" | ||||||||||||||||||||||||||
|
|
@@ -73,7 +73,7 @@ jobs: | |||||||||||||||||||||||||
| - name: Checkout repository | ||||||||||||||||||||||||||
| uses: actions/checkout@v5 | ||||||||||||||||||||||||||
| with: | ||||||||||||||||||||||||||
| fetch-depth: 0 | ||||||||||||||||||||||||||
| fetch-depth: 1 | ||||||||||||||||||||||||||
| repository: ${{ github.event.pull_request.head.repo.full_name }} | ||||||||||||||||||||||||||
|
Comment on lines
74
to
77
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❓ Verification inconclusivePlease confirm shallow checkout still yields the correct package version. The new build metadata embeds git tags/hashes; reducing 🏁 Script executed: #!/bin/bash
set -euo pipefail
# Expectation: succeeds and prints the tag that scikit-build-core uses.
git describe --tags --abbrev=0Length of output: 48 Ensure tags are fetched for version computation 🤖 Prompt for AI Agents |
||||||||||||||||||||||||||
| ref: ${{ github.event.pull_request.head.ref }} | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
|
|
@@ -111,6 +111,7 @@ jobs: | |||||||||||||||||||||||||
| run: | | ||||||||||||||||||||||||||
| echo "Installing project (wheel form)" | ||||||||||||||||||||||||||
| source "${{ runner.tool_cache }}/${{ env.VENV_DIR }}/bin/activate" | ||||||||||||||||||||||||||
| git submodule update --init --recursive --checkout --recommend-shallow | ||||||||||||||||||||||||||
| USE_ROCM=True pip install . --no-user | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
|
Comment on lines
112
to
116
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Submodules must be synced before the first
Apply this diff inside the “Ensure venv (local & persistent)” step: if [[ -f requirements-rocm.txt ]]; then
pip install --pre torch torchvision torchaudio --index-url ${{ env.PYTORCH_INDEX_URL }}
PIP_NO_BUILD_ISOLATION=1 pip install -r requirements-rocm.txt
fi
- USE_ROCM=True pip install . --no-user
+ git submodule update --init --recursive --checkout --recommend-shallow
+ USE_ROCM=True pip install . --no-user
touch "$MARKER"📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||
| - name: Run tests | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.