Skip to content

[Enhancement] Update ReduceOp initialization values for integer types #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeiWang1999 merged 2 commits into from
Jul 8, 2025
Merged

[Enhancement] Update ReduceOp initialization values for integer types #614

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4abdf4
[Enhancement] Update ReduceOp initialization values for integer types
LeiWang1999 Jul 7, 2025
a9f0fac
[Enhancement] Update ReduceOp to handle unsigned integer initializati…
LeiWang1999 Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/op/reduce.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,32 @@ ReduceOp::ReduceOp(Array<PrimExpr> args, BufferMap vmap) {
}

PrimExpr ReduceOp::MakeInitValue() const {
auto dst_dtype = dst->dtype;
auto is_int = dst_dtype.is_int();
bool is_uint = dst_dtype.is_uint();
auto bits = dst_dtype.bits();

switch (type) {
case ReduceType::kSum:
return make_zero(dst->dtype);
case ReduceType::kAbsSum:
return make_zero(dst->dtype);
case ReduceType::kMax:
return make_const(dst->dtype, -INFINITY);
if (is_int) {
return make_const(dst->dtype, -(1 << (bits - 1)));
} else if (is_uint) {
return make_const(dst->dtype, 0);
} else {
return make_const(dst->dtype, -INFINITY);
}
case ReduceType::kMin:
return make_const(dst->dtype, INFINITY);
if (is_int) {
return make_const(dst->dtype, (1 << (bits - 1)) - 1);
} else if (is_uint) {
return make_const(dst->dtype, (1 << bits) - 1);
} else {
return make_const(dst->dtype, INFINITY);
}
case ReduceType::kAbsMax:
return make_const(dst->dtype, 0);
default:
Expand Down
Loading