Skip to content

Conversation

@kurisu6912
Copy link
Collaborator

@kurisu6912 kurisu6912 commented Feb 5, 2026

as title.

Summary by CodeRabbit

  • New Features
    • Added a new configuration option to disable out-of-bounds memory access warnings during compilation.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run pre-commit run --all-files in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

This PR adds a new pass configuration option to control out-of-bounds warnings in safe memory access legalization. The feature registers kDisableOutOfBoundWarning as a Bool configuration across C++ and Python layers, then integrates it into SafeMemChecker to conditionally suppress OOB warnings.

Changes

Cohort / File(s) Summary
Configuration Registration
src/op/builtin.cc, src/op/builtin.h, tilelang/transform/pass_config.py
Added new pass configuration option kDisableOutOfBoundWarning with value "tl.disable_out_of_bound_warning" across C++ and Python configuration systems.
Logic Integration
src/transform/legalize_safe_memory_access.cc
Integrated the new disableOOBWarning flag into SafeMemChecker; modified out-of-bounds warning condition to suppress warnings when flag is set or buffer is global; added helper methods IsGlobalBuffer and CheckBufferIndices.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • chengyupku

Poem

🐰 Hopping through the bounds so tight,
A warning flag takes flight,
Skip the noise, or let it show,
Config whispers: fast or slow,
Memory dances left and right!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly describes the main feature: adding an option to disable out-of-bound access warnings in safe memory access legalization, which aligns with all changes across the four modified files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@LeiWang1999 LeiWang1999 merged commit 5951bce into tile-ai:main Feb 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants