Skip to content

Conversation

@oraluben
Copy link
Collaborator

@oraluben oraluben commented Feb 4, 2026

Fixes an issue mentioned in wechat group.

The fix is a side effect of cython pr: cython/cython#6055

Also fixes a ci failure in python 3.9 cc @SiriusNEO

Summary by CodeRabbit

  • Chores
    • Bumped build-system requirements to a newer Cython version for improved build compatibility.
  • Refactor
    • Adjusted public type annotations for broader Python compatibility.
    • Added a small public alias to clarify buffer-like types.

@oraluben oraluben requested a review from LeiWang1999 February 4, 2026 10:10
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run pre-commit run --all-files in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

Replaces Python 3.10 union syntax with typing.Union in public type aliases and adds a new BufferLikeTypeTuple; also bumps Cython build-system requirement from >=3.0.0 to >=3.1.0 in pyproject.toml.

Changes

Cohort / File(s) Summary
Build System Dependencies
pyproject.toml
Bump Cython build requirement from >=3.0.0 to >=3.1.0.
Typing Public API
tilelang/_typing.py
Replace `A

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 A nibble of types, unions made new,
I hopped through hints and tightened the glue.
Cython climbed a notch, the build hums along —
I celebrate with a twitch and a tiny song. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title mentions fixing an issue with Cython 3.0 and Python stable API, but the actual changes involve bumping Cython to 3.1.0 and converting union syntax to typing.Union for Python 3.9 compatibility. Consider whether the title should be more specific about Python 3.9 compatibility or the Cython version requirement change, as these are the main technical changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@oraluben oraluben requested review from SiriusNEO and removed request for SiriusNEO February 4, 2026 10:31
@oraluben oraluben merged commit 841c446 into tile-ai:main Feb 5, 2026
13 checks passed
@oraluben oraluben deleted the upd-cython branch February 5, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants