[BugFix] Fix type annotations for T.reshape and T.view (#1768)Fix type annotations for T.reshape and T.view#1773
Conversation
|
👋 Hi! Thank you for contributing to the TileLang project. Please remember to run We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀 |
📝 WalkthroughWalkthroughThe PR updates type annotations in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@ShaobinChen-AH Thank you for contributing to TileLang! We are planning a systematic overhaul of our type annotations, so this issue will be resolved as part of that larger effort. I'll close this PR for now, but thanks again. |
Fixes #1768
Problem:
The type annotations for
T.reshapeandT.viewwere too strict, causing type checkers (like mypy/Pylance) to incorrectly flag valid code: