Skip to content

Conversation

@kurisu6912
Copy link
Collaborator

@kurisu6912 kurisu6912 commented Jan 29, 2026

as title

Summary by CodeRabbit

  • Documentation
    • Updated example function signature with explicit input/output tensor declarations and optional block size parameters
    • Extended README with instructions for compilation, profiling, and multiple kernel invocations

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run pre-commit run --all-files in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 29, 2026

📝 Walkthrough

Walkthrough

The README example refactors a matmul function to matmul_relu, transitioning from parameter-based inputs (M, N, K) to explicit tensor arguments (A, B), adding ReLU operation, and shifting return semantics from a kernel object to the computed output tensor.

Changes

Cohort / File(s) Summary
README Example Update
README.md
Replaces matmul example with matmul_relu function: changes signature to accept tensors A, B instead of dimensions; adds ReLU operation; reorganizes kernel orchestration and memory allocation; updates return to tensor C; includes compilation and profiling instructions; adjusts block size parameters with default values.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰 With tensors as inputs, the flow now feels bright,
A and B dance together, ReLU shines light,
From kernels returned to tensors displayed,
The README example's been newly remade! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title '[EagerJIT] Update README example to eager jit' is partially related to the changeset—it accurately reflects that the README is being updated and mentions eager JIT, but it lacks specificity about the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@README.md`:
- Around line 157-185: The example uses T.ceildiv(...) and tile buffers
(A_shared, B_shared, C_local) with T.copy/T.gemm/T.clear but lacks edge-tile
bounds protection, so add explicit per-tile boundary guards or masking before
any global memory loads/stores: check tile-global ranges computed from bx/by/ko
against M/N/K and only copy valid elements into A_shared/B_shared and only write
valid elements from C_local back via the final T.copy, and also guard the relu
loop over i,j to skip out-of-range indices; alternatively, update the README
example text to state that M, N, and K must be exact multiples of block_M,
block_N, and block_K and call out that the current code requires this
divisibility.

@LeiWang1999 LeiWang1999 merged commit 8e1358d into tile-ai:main Jan 29, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants