[BugFix] Fix FP4 related vectorized cast#1741
Conversation
|
👋 Hi! Thank you for contributing to the TileLang project. Please remember to run We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀 |
📝 WalkthroughWalkthroughNarrowed vectorized FP8/FP4 cast paths by adding explicit 32-bit width checks to casting logic in CUDA codegen, while expanding type-casting rules in utilities to support additional float type conversions. Test suite reorganized to isolate FP8 conversion tests into dedicated blocks. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~28 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SiriusNEO
left a comment
There was a problem hiding this comment.
LGTM. BTW, I think we need methods like is_float32() and is_float64() in tvm DataType.
Summary by CodeRabbit
Release Notes
Improvements
Tests
✏️ Tip: You can customize this high-level summary in your review settings.