[Refactor] re-implement vector subtype and its access method#1722
[Refactor] re-implement vector subtype and its access method#1722LeiWang1999 merged 1 commit intotile-ai:mainfrom
Conversation
- Refactored `fp4_e2_2_t` structure to include methods for accessing and setting low and high bits. - Updated `PrintVecElemLoad` and `PrintVecElemStore` methods in `codegen_cuda.cc` to reflect changes in member access for `fp4_e2_4_t` and `fp4_e2_2_t`. - Adjusted test for `tilelang_copy_fp4` to ensure correct input dimensions and output validation based on data type consistency.
|
👋 Hi! Thank you for contributing to the TileLang project. Please remember to run We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀 |
📝 WalkthroughWalkthroughThis PR refactors FP4-e2m1 tensor storage and access patterns in CUDA. It replaces direct member access with a new encapsulated Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
as title. Thanks for @Hamerlate to provide the test machine
Summary by CodeRabbit
Refactor
Tests
✏️ Tip: You can customize this high-level summary in your review settings.