-
Notifications
You must be signed in to change notification settings - Fork 450
[Release] Fix release wheels #1687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the TileLang project. Please remember to run We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀 |
📝 WalkthroughWalkthroughConsolidates release detection in Changes
Sequence Diagram(s)(omitted — changes are confined to a single CI workflow file and do not introduce multi-component runtime flows) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
83dd08f to
bfa4627
Compare
bfa4627 to
c81fbc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/dist.yml:
- Around line 171-178: The conditional currently uses [[ ${{ env.IS_RELEASE }}
]] which treats the literal "false" as truthy; change the check to perform an
explicit string comparison against "true" (e.g., [[ "${{ env.IS_RELEASE }}" ==
"true" ]]) and keep the existing nested check on matrix.target.toolkit
(referencing matrix.target.toolkit) and the env writes to NO_GIT_VERSION and
NO_VERSION_LABEL so the branch only runs when IS_RELEASE is truly "true".
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.