Skip to content

Conversation

@LeiWang1999
Copy link
Member

@LeiWang1999 LeiWang1999 commented Jan 9, 2026

as title.

Summary by CodeRabbit

  • Refactor

    • Improved detection and handling of synchronization operations for enhanced internal efficiency.
  • Tests

    • Strengthened validation of generated kernel code quality.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run pre-commit run --all-files in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀

@LeiWang1999 LeiWang1999 merged commit d06fc9c into tile-ai:main Jan 9, 2026
2 of 4 checks passed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 9, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Two transform modules replace string-based CUDA PDL operation detection with direct operation node checks (pdl_trigger and pdl_sync), and a test adds validation asserting the absence of a specific string in generated kernel output.

Changes

Cohort / File(s) Summary
PDL Operation Detection Refactoring
src/transform/lower_pdl.cc, src/transform/warp_specialized_rewriter.cc
Replace string-argument parsing of extern calls with direct operation node checks; set has_trigger_launch_ and has_grid_sync_ flags directly via tl::pdl_trigger() and tl::pdl_sync() equality comparisons instead of matching CUDA PDL function names from call arguments.
PDL Sync Test Assertion
testing/python/language/test_tilelang_language_pdl.py
Add assertion verifying generated CUDA kernel source does not contain __restrict__ string.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 From strings to ops, the PDL now flows clear,
No more parsing names—the trigger's right here!
PDL sync checks swift, without the fuss,
Refactored with grace, more elegant thus!

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 409677d and 4b396f3.

📒 Files selected for processing (3)
  • src/transform/lower_pdl.cc
  • src/transform/warp_specialized_rewriter.cc
  • testing/python/language/test_tilelang_language_pdl.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant